-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Latched map subscriber QoS depth 1 #5665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SteveMacenski
merged 4 commits into
ros-navigation:main
from
botsandus:match_latched_sub
Nov 24, 2025
Merged
Latched map subscriber QoS depth 1 #5665
SteveMacenski
merged 4 commits into
ros-navigation:main
from
botsandus:match_latched_sub
Nov 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Doisy <[email protected]>
SteveMacenski
requested changes
Nov 15, 2025
Signed-off-by: Guillaume Doisy <[email protected]>
9229051 to
11fbcfa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Guillaume Doisy <[email protected]>
SteveMacenski
approved these changes
Nov 24, 2025
Decwest
pushed a commit
to Decwest/navigation2
that referenced
this pull request
Dec 10, 2025
* Latched map subscriber QoS depth 1 Signed-off-by: Guillaume Doisy <[email protected]> * 3 Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]>
Decwest
pushed a commit
to Decwest/navigation2
that referenced
this pull request
Dec 11, 2025
* Latched map subscriber QoS depth 1 Signed-off-by: Guillaume Doisy <[email protected]> * 3 Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Decwest <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Change the depth of the map and costmap related subscribers from 10 (default) to 1 (explicitly through the constructor
nav2::qos::LatchedSubscriptionQoS(1)). This matches the depth of the latched publishers (default depth of 1).This is needed for us in the context of using huge maps + Zenoh SHM in order to not have to set ZENOH_SHM_ALLOC_SIZE to the size of the message * [10 (the depth of the subscriber) + 2 (recommended margin)] and optimizing RAM usage.
This works well for our setup (all comms are local). Though a point to discuss is if this could cause issues for receiving map/costmap over wireless / lossy connections. But since we are only touching latched topics (and matching the publishers), I am not sure it is really an issue.
An alternative would be to have the user override the QoS of these subscribers.
(side change: use nav2::qos for test_map_saver_cli and test_map_saver_publisher)
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.