Skip to content

Fix QoS for is_active publisher in LifecycleManager#5630

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Sushant-Chavan:fix/publisher_qos
Oct 21, 2025
Merged

Fix QoS for is_active publisher in LifecycleManager#5630
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Sushant-Chavan:fix/publisher_qos

Conversation

@Sushant-Chavan
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses -
Primary OS tested on Ubuntu
Robotic platform tested on Simulation
Does this PR contain AI generated software? No
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

Fix QoS for is_active publisher in LifecycleManager that was recently added in #5627. The depth of the publisher should be set to 1 to avoid publishing historical states to late subscribers

Description of documentation updates required from your changes

N/A

Description of how this change was tested

Echo the topic after the Nav stack has transitioned to active state. A single message should be shown with is_active=True rather than getting two messages is_active=False followed by is_active=True.

Future work that may be required in bullet points

N/A

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
nav2_lifecycle_manager/src/lifecycle_manager.cpp 90.10% <100.00%> (-1.07%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski SteveMacenski merged commit 0778f56 into ros-navigation:main Oct 21, 2025
16 checks passed
greganderson-vermeer pushed a commit to greganderson-vermeer/navigation2-vermeer-features that referenced this pull request Oct 22, 2025
…#5630)

Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
decwest pushed a commit to decwest/navigation2 that referenced this pull request Dec 10, 2025
…#5630)

Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
decwest pushed a commit to decwest/navigation2 that referenced this pull request Dec 11, 2025
…#5630)

Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants