Fix QoS for is_active publisher in LifecycleManager#5630
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Oct 21, 2025
Merged
Fix QoS for is_active publisher in LifecycleManager#5630SteveMacenski merged 1 commit intoros-navigation:mainfrom
is_active publisher in LifecycleManager#5630SteveMacenski merged 1 commit intoros-navigation:mainfrom
Conversation
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
a8142d3 to
df3544d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
SteveMacenski
approved these changes
Oct 21, 2025
greganderson-vermeer
pushed a commit
to greganderson-vermeer/navigation2-vermeer-features
that referenced
this pull request
Oct 22, 2025
…#5630) Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
decwest
pushed a commit
to decwest/navigation2
that referenced
this pull request
Dec 10, 2025
…#5630) Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
decwest
pushed a commit
to decwest/navigation2
that referenced
this pull request
Dec 11, 2025
…#5630) Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Fix QoS for
is_activepublisher in LifecycleManager that was recently added in #5627. The depth of the publisher should be set to 1 to avoid publishing historical states to late subscribersDescription of documentation updates required from your changes
N/A
Description of how this change was tested
Echo the topic after the Nav stack has transitioned to active state. A single message should be shown with is_active=True rather than getting two messages
is_active=Falsefollowed byis_active=True.Future work that may be required in bullet points
N/A
For Maintainers:
backport-*.