Skip to content

Fixing CI Cache Misalignment causing builds to fail#5607

Merged
SteveMacenski merged 3 commits intomainfrom
fix_ci
Oct 14, 2025
Merged

Fixing CI Cache Misalignment causing builds to fail#5607
SteveMacenski merged 3 commits intomainfrom
fix_ci

Conversation

@SteveMacenski
Copy link
Member

@SteveMacenski SteveMacenski commented Oct 13, 2025

No description provided.

@SteveMacenski
Aligning caches
9f07ee1 
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
@SteveMacenski
Trigger linting (hopefully)
7f15cb8 
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
@SteveMacenski
Fix action-ros-lint version format in lint.yml
7e32cd6 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@leander-dsouza
Copy link
Contributor

leander-dsouza commented Oct 14, 2025 •
edited
Loading

I think a rebase is required on this branch, as the declare_or_get_parameter function was not added to the lifecycle_node.hpp for parameters not having a default value until #5588.

If you test the package against the main branch, it should pass locally:

$ colcon build --packages-select nav2_map_server && colcon test --packages-select nav2_map_server && colcon test-result --verbose

Summary: 3698 tests, 0 errors, 0 failures, 722 skipped

@SteveMacenski SteveMacenski merged commit 3935038 into main Oct 14, 2025
13 of 14 checks passed
@SteveMacenski SteveMacenski deleted the fix_ci branch October 14, 2025 14:48
Jad-ELHAJJ pushed a commit to Jad-ELHAJJ/navigation2 that referenced this pull request Oct 16, 2025
@SteveMacenski @Jad-ELHAJJ
Fixing CI Cache Misalignment causing builds to fail (ros-navigation#5607
2659cd7 
)

* Aligning caches

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Trigger linting (hopefully)

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix action-ros-lint version format in lint.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
greganderson-vermeer pushed a commit to greganderson-vermeer/navigation2-vermeer-features that referenced this pull request Oct 21, 2025
@SteveMacenski @greganderson-vermeer
Fixing CI Cache Misalignment causing builds to fail (ros-navigation#5607
07d2494 
)

* Aligning caches

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Trigger linting (hopefully)

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix action-ros-lint version format in lint.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
greganderson-vermeer added a commit to greganderson-vermeer/navigation2-vermeer-features that referenced this pull request Oct 21, 2025
@greganderson-vermeer
Squashing commits in this branch to clear commits missing signatures.
b15cca4 
Squashed commit of the following:

commit bf2e64c
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Tue Oct 21 14:41:42 2025 -0500

    Add declaration for use_global_height parameter into add sources
    function.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit 8453632
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Tue Oct 21 08:28:19 2025 -0500

    Adjusted asserts in third test case for consistent results.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit 725f054
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Mon Oct 20 21:04:51 2025 -0500

    Add additional case for testing pointcloud with no height field.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit 2bb49aa
Merge: b02713a cdccfe1
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Mon Oct 20 18:01:24 2025 -0500

    Merge branch 'main' into feat/CustomCollisionPointFields

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit b02713a
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Mon Oct 20 17:53:36 2025 -0500

    Cleaned up some un-needed parameter changes.

commit 21eef62
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Mon Oct 20 17:49:16 2025 -0500

    Added test case for using global height parameter.

commit cdccfe1
Author: Sushant Chavan <gitecsvc@gmail.com>
Date:   Mon Oct 20 23:49:25 2025 +0200

    Publish `is_active` status from LifecycleManager (ros-navigation#5627)

    * Publish `is_active` status from LifecycleManager

    Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>

    * Update nav2_lifecycle_manager/src/lifecycle_manager.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    ---------

    Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

commit b35a4b5
Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Date:   Mon Oct 20 22:04:17 2025 +0100

    Use the new declare_or_get_parameter API for nav2_controller. (ros-navigation#5624)

    * Migrate majority of parameter declarations to use the new parameter API.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Migrate controller_server.cpp to use declare_or_get_parameter API.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    ---------

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

commit 62ebc54
Author: Steve Macenski <stevenmacenski@gmail.com>
Date:   Thu Oct 16 07:59:10 2025 -0700

    Revert "[RPP] Prevent collision check premature termination (ros-navigation#5598)" (ros-navigation#5620)

    This reverts commit 6bc74e5.

commit 01580bd
Author: mini-1235 <mauricepurnawan@gmail.com>
Date:   Thu Oct 16 02:02:29 2025 +0700

    Redesign graceful controller dynamic parameters patterns (ros-navigation#5600)

    Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

commit b91eda5
Author: Abhishekh Reddy <helloarm@pm.me>
Date:   Tue Oct 14 14:47:14 2025 -0400

    Check if the tolerance circle is feasible when validating goals for path planning. (ros-navigation#5593)

    * Implemented goal tolerance validity check

    Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

    * Fixed description for getCoords function

    Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

    * Added a test with lower tolerance for zone validity checking

    Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

    * Updated tolerance check function implementation

    Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

    * Updated isZoneValid function

    Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

    * Updated isZoneValid function

    Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

    ---------

    Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

commit 48e7e06
Author: Jay Herpin <159202566+JayHerpin@users.noreply.github.com>
Date:   Tue Oct 14 12:45:59 2025 -0500

    Fixed crash due to incorrect string construction (ros-navigation#5606)

    Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com>

commit 7d37466
Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Date:   Tue Oct 14 15:50:30 2025 +0100

    Use the new parameter API in nav2_constrained_smoother. (ros-navigation#5608)

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

commit 3935038
Author: Steve Macenski <stevenmacenski@gmail.com>
Date:   Tue Oct 14 07:48:32 2025 -0700

    Fixing CI Cache Misalignment causing builds to fail (ros-navigation#5607)

    * Aligning caches

    Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

    * Trigger linting (hopefully)

    Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

    * Fix action-ros-lint version format in lint.yml

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    ---------

    Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

commit 568174c
Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Date:   Tue Oct 14 01:41:25 2025 +0100

    Update new_declare_or_get_parameter API for collision_monitor and map_server (ros-navigation#5588)

    * Use the new_declare_or_get_parameter API for nav2_collision_monitor.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Removed redundant set_parameter calls when preceeded by declare_parameter.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Use declare_or_get_parameter without a default value.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Simplified definitions that required to determine parameter type from template.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Removed self-definition of node_utils.hpp.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Address PR feedback: Remove unnecessary linebreaks and improve param docstring.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    ---------

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

commit 6bc74e5
Author: Érico Meger <86668447+EricoMeger@users.noreply.github.com>
Date:   Mon Oct 13 19:17:23 2025 -0300

    [RPP] Prevent collision check premature termination (ros-navigation#5598)

    * prevent collision check premature termination

    Signed-off-by: EricoMeger <ericomeger9@gmail.com>

    * improve comment wording

    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    Signed-off-by: Érico Meger <86668447+EricoMeger@users.noreply.github.com>

    * fix linting error

    Signed-off-by: EricoMeger <ericomeger9@gmail.com>

    ---------

    Signed-off-by: EricoMeger <ericomeger9@gmail.com>
    Signed-off-by: Érico Meger <86668447+EricoMeger@users.noreply.github.com>
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

commit 4d28c13
Author: silanus <berkantali23@outlook.com>
Date:   Fri Oct 10 20:42:45 2025 +0300

    Path distance feature (ros-navigation#5387)

    * geometry utils

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * fixed geometry utils adding 2d

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * created path_utils

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * added tests

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * minor changes in tests

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * lint issue

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * fixed reviews

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * doxygen fix

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Last fixes.

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Last fixes cpp.

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Update nav2_util/include/nav2_util/path_utils.hpp

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    Signed-off-by: silanus <berkantali23@outlook.com>
    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Update nav2_util/include/nav2_util/path_utils.hpp

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    Signed-off-by: silanus <berkantali23@outlook.com>
    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Update nav2_util/test/test_path_utils.cpp

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    Signed-off-by: silanus <berkantali23@outlook.com>
    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Frame check fix

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * msg

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * controller server publisher

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * controller server publisher fix

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * cross_product

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * handled last_fixes

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * tracking error added to follow path
    side from side added to tracking error

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * arranged msgs

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * linting of msgs

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * last cpplint

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * frame check for distance_to_goal

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * fixes for follow_path

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * controller linting

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * changing tracking_error to tracking_error_feedback

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * adding remaining_path_length in tracking_error_feedback

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Last fix

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * start_index_

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Name changes and optimizations in controller_server and nav2_util

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Changing name to tracking_feedback

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Documentation changes

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Last lint

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Update nav2_util/include/nav2_util/path_utils.hpp

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    Signed-off-by: silanus <berkantali23@outlook.com>

    * Update nav2_controller/src/controller_server.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    * Update nav2_controller/src/controller_server.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    * Update nav2_controller/src/controller_server.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    * Update nav2_controller/src/controller_server.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    * Update nav2_controller/src/controller_server.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    * Last updates

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * update example_follow_path.py

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * update example_follow_path.py lint

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Update nav2_controller/src/controller_server.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    * Update nav2_controller/src/controller_server.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    * Update nav2_util/src/path_utils.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    * ordering problem

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * added deactivate to tracking_feedback_pub_

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * typo

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * end_pose transform

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * creating the member variable end_pose_global_ and deleting nav_2d_msgs

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * deleting unnecessary transform

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * typo in controller

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * readding remaining path

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * placement of transformation

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * unnecessary comments

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * tests added

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Increased test coverage

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Every part of the result is covered

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Increasing out of bounds index

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * lint

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * add missing line to cmake

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * unnecessary test

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * unexptected styling and last functional change

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * simplifying the tranformation of end_pose

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * doxygen fix

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * doxygen fix

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * doxygen fix

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * doxygen fix

    Signed-off-by: silanus23 <berkantali23@outlook.com>

    * Update nav2_controller/src/controller_server.cpp

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

    ---------

    Signed-off-by: silanus23 <berkantali23@outlook.com>
    Signed-off-by: silanus <berkantali23@outlook.com>
    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

commit 04a3e22
Author: Steve Macenski <stevenmacenski@gmail.com>
Date:   Fri Oct 10 10:09:08 2025 -0700

    Improve error message for missing robot footprint (ros-navigation#5597)

    Updated error message for footprint collision checking.

    Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

commit ce6b439
Author: Alberto Tudela <ajtudela@gmail.com>
Date:   Fri Oct 10 00:12:57 2025 +0200

    Following (ros-navigation#5565)

    * Following server

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * feat: migrate to nav2_msgs for FollowObject action and remove opennav_following_msgs

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * Fix mypy test

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * Move FollowObject and FollowObjectCancel action nodes from bt package

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * Update package and circle

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * feat: add FollowObject action support in robot navigator and fix mypy

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * Fix mypy issues

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * feat: add follow_object action to bt_navigator parameters

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * Update key and package

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * Fix precommit

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * Fix mypy?

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    * Fix mypy, round two

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

    ---------

    Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

commit ed0d59f
Author: Sakshay Mahna <sakshum19@gmail.com>
Date:   Thu Oct 9 03:39:30 2025 +0530

    [Graceful Controller] Fix Incorrect Motion Target Heading output by controller (ros-navigation#5530)

    * Fix graceful controller lookahead bug

    Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

    * Shorten logic with goal_pose

    Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

    * Add Linear Interpolation Fix

    Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

    * Update const double and comments

    Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

    ---------

    Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

commit 14660b4
Author: Vince Reda <60265874+redvinaa@users.noreply.github.com>
Date:   Wed Oct 8 17:14:57 2025 +0000

    Fail PersistentSequence if input port is not set (ros-navigation#5589)

    * Fail if getInput fails

    Signed-off-by: redvinaa <redvinaa@gmail.com>

    * Add test with no input

    Signed-off-by: redvinaa <redvinaa@gmail.com>

    * Update error string

    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    Signed-off-by: Vince Reda <60265874+redvinaa@users.noreply.github.com>

    * Fix quotation marks

    Signed-off-by: redvinaa <redvinaa@gmail.com>

    ---------

    Signed-off-by: redvinaa <redvinaa@gmail.com>
    Signed-off-by: Vince Reda <60265874+redvinaa@users.noreply.github.com>
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

commit aa2cdc5
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Wed Oct 8 10:43:14 2025 -0500

    Apply suggestions from code review

    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit 5636fc1
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Tue Oct 7 15:37:13 2025 -0500

    Implementing Steve's suggestion for performance and
    code simplicity.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit b2fbb06
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Tue Oct 7 12:59:46 2025 -0500

    Implemented additional changes for iterator feedback
    in PR.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit 1cdbc05
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Tue Oct 7 12:12:31 2025 -0500

    Add return false for error state.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit 869b5a9
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Tue Oct 7 12:10:03 2025 -0500

    Address PR formatting feedback.
    Remove run time error and replaced with log error.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit 11f04c7
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Tue Oct 7 10:55:18 2025 -0500

    Added some pointcloud field checking based on run time
    error found when running tests.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit ca49b05
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Tue Oct 7 08:22:05 2025 -0500

    Ran ament lint/style tools, cleaned up.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit 7e6ccc9
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Tue Oct 7 08:08:01 2025 -0500

    Add use_global_height_ parameter to allow configuration
    of height checking by end users.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

commit 0c20df2
Author: DylanDeCoeyer-Quimesis <102609575+DylanDeCoeyer-Quimesis@users.noreply.github.com>
Date:   Mon Oct 6 22:29:17 2025 +0200

    nav2_smac_planner: make A* return closest path found in case of timeout (ros-navigation#5578)

    Until now, a path computation timeout would systematically lead to a
    nav2_core::PlannerTimedOut error, even though a path was found within
    the tolerance.

    This commit makes the A* return the best path found if it's within the
    tolerance.

    Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be>

commit f78bac5
Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Date:   Mon Oct 6 20:16:30 2025 +0100

    Use the new declare_or_get_parameter API for nav2_behaviors. (ros-navigation#5583)

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

commit 269d480
Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Date:   Mon Oct 6 20:13:52 2025 +0100

    Improve type annotations for ament_mypy (ros-navigation#5575)

    * Enable tools directory to be mypy compliant.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Enable nav2_system_tests to be mypy compliant.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Enable nav2_docking to be mypy compliant.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Enable nav2_simple_commander to be mypy compliant.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Enable nav2_loopback_sim to be mypy compliant.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Removed unused ignores for packages for mypy compliance.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    * Added nav2_msgs path fixes to mypy compliance.

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

    ---------

    Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

commit 5860a27
Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Date:   Mon Oct 6 12:41:04 2025 -0500

    Create iterator for custom height field in pointcloud.

    Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
greganderson-vermeer pushed a commit to greganderson-vermeer/navigation2-vermeer-features that referenced this pull request Oct 22, 2025
@SteveMacenski @greganderson-vermeer
Fixing CI Cache Misalignment causing builds to fail (ros-navigation#5607
39dcdff 
)

* Aligning caches

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Trigger linting (hopefully)

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix action-ros-lint version format in lint.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
decwest pushed a commit to decwest/navigation2 that referenced this pull request Dec 10, 2025
@SteveMacenski @decwest
Fixing CI Cache Misalignment causing builds to fail (ros-navigation#5607
dcc9be2 
)

* Aligning caches

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Trigger linting (hopefully)

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix action-ros-lint version format in lint.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
decwest pushed a commit to decwest/navigation2 that referenced this pull request Dec 11, 2025
@SteveMacenski @decwest
Fixing CI Cache Misalignment causing builds to fail (ros-navigation#5607
f3ec675 
)

* Aligning caches

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Trigger linting (hopefully)

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix action-ros-lint version format in lint.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SteveMacenski @leander-dsouza