Replace rclcpp::spin_some and rclcpp::spin_all#5521
Merged
SteveMacenski merged 6 commits intoros-navigation:mainfrom Sep 16, 2025
Merged
Replace rclcpp::spin_some and rclcpp::spin_all#5521SteveMacenski merged 6 commits intoros-navigation:mainfrom
SteveMacenski merged 6 commits intoros-navigation:mainfrom
Conversation
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
SteveMacenski
requested changes
Sep 15, 2025
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Contributor
|
@mini-1235, your PR has failed to build. Please check CI outputs and resolve issues. |
SteveMacenski
approved these changes
Sep 16, 2025
This was referenced Sep 17, 2025
Merged
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Sep 18, 2025
* Get rid of rclcpp spin all and spin some Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Vector object server Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_rviz_plugins/src/utils.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Error log Signed-off-by: Maurice <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
BCKSELFDRIVEWORLD
pushed a commit
to BCKSELFDRIVEWORLD/navigation2
that referenced
this pull request
Sep 23, 2025
* Get rid of rclcpp spin all and spin some Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Vector object server Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_rviz_plugins/src/utils.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Error log Signed-off-by: Maurice <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Oct 11, 2025
* Get rid of rclcpp spin all and spin some Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Vector object server Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_rviz_plugins/src/utils.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Error log Signed-off-by: Maurice <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
nav2_rviz_pluginsDescription of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.