[BtActionServer] default empty search_directories in constructor#5518
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Sep 10, 2025
Merged
Conversation
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
8 tasks
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
SteveMacenski
approved these changes
Sep 10, 2025
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
I ack this - but also this is actually a neat feature. I’d recommend checking it out! You can call actions by a tree’s name rather than by filepath!
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
BCKSELFDRIVEWORLD
pushed a commit
to BCKSELFDRIVEWORLD/navigation2
that referenced
this pull request
Sep 23, 2025
Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
In relation to #5426 (comment)
Make
search_directoriesoptional to not break external use ofBtActionServer(without a migration step).cc @Jad-ELHAJJ
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.