Make MPPI Controller and Critics Apple Clang Friendly#5455
Make MPPI Controller and Critics Apple Clang Friendly#5455SteveMacenski merged 3 commits intoros-navigation:mainfrom
Conversation
Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
|
with recent changes, Only mppi_critics target will require C++20. CMake will automatically add -std=c++20 (or the equivalent) just for this target, leaving all other targets at their current C++ standard. This is safer and avoids impacting the rest of the build. had to update |
SteveMacenski
left a comment
There was a problem hiding this comment.
Is there no way around this other than changing the cpp version? That's a kind of extreme move IMO
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.5) | |||
| cmake_minimum_required(VERSION 3.8) | |||
There was a problem hiding this comment.
Can you search + replace in the CMakeLists to update them all to 3.8? Consistency is nice :-)
There was a problem hiding this comment.
Can you search + replace in the CMakeLists to update them all to 3.8? Consistency is nice :-)
Sure 👍
i will add them in To-do. I’ll do the change when I switch to working with Rolling on macOS if its fine, since my current work and build checks are happening on Humble right now. (will begin soon).
right now i couldnt find any. let me try for some more time if i can find a another way arround. |
SteveMacenski
left a comment
There was a problem hiding this comment.
Can you update the 3.5 to 3.8 here? CI will pick up on rolling if there are any issues. I don't like to leave things in inconsistent states, though I appreciate your desire to test on Humble first :-)
sure i will be on it. |
Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
…#5455) * fix: adjust C++ standard and compiler flags for Apple Clang Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com> * Update: Only mppi_critics target will require C++20 Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com> * cmake_minimum_required(VERSION 3.8) update Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com> --------- Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
…#5455) * fix: adjust C++ standard and compiler flags for Apple Clang Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com> * Update: Only mppi_critics target will require C++20 Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com> * cmake_minimum_required(VERSION 3.8) update Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com> --------- Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
…#5455) * fix: adjust C++ standard and compiler flags for Apple Clang Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com> * Update: Only mppi_critics target will require C++20 Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com> * cmake_minimum_required(VERSION 3.8) update Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com> --------- Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
CMakeLists.txtto avoid-fconceptsflag, which is unsupported.C++20for Apple Clang to supportConceptsnatively.