Construct TF listeners passing nodes, spinning on separate thread (backport #5406)#5432
Merged
SteveMacenski merged 1 commit intokiltedfrom Aug 8, 2025
Merged
Conversation
) * Construct TF listeners passing nodes, spinning on separate thread Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com> * (tentative) pin down of the impacting change Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com> --------- Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com> (cherry picked from commit 1468484)
Contributor
Author
SteveMacenski
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1182 - this is a re-assessment after 6 years.
Advantages: easier auditing of TF2 subscriptions across the ROS graph. The nav2 node(s) name(s) will appear for example when issuing
ros2 topic info -v /tf.Basic Info
Description of contribution in a few bullet points
Construct
tf2_ros::TransformListenerinstances passing a node pointer, so that no additional nodes with randomized names are spawned on the ROS graph (less pollution, better auditing), but enabling thespin_threadflag, so that we ensure TF subscriptions are not interleaved with other nav2-related callbacks in the same executor.For Maintainers:
backport-*.This is an automatic backport of pull request #5406 done by [Mergify](https://mergify.com).