Make pause resume controller use nav2::LifecycleNode#5427
Merged
SteveMacenski merged 4 commits intoros-navigation:mainfrom Aug 8, 2025
Merged
Make pause resume controller use nav2::LifecycleNode#5427SteveMacenski merged 4 commits intoros-navigation:mainfrom
SteveMacenski merged 4 commits intoros-navigation:mainfrom
Conversation
Contributor
|
@redvinaa, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: redvinaa <redvinaa@gmail.com>
024ef44 to
85d0677
Compare
Contributor
|
@redvinaa, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: redvinaa <redvinaa@gmail.com>
SteveMacenski
approved these changes
Aug 7, 2025
Member
|
@redvinaa this causes an interesting failure: |
Contributor
Author
|
Uups sorry.. At my company we use jazzy so it's very easy to make a mistake developing directly to rolling. |
Signed-off-by: redvinaa <redvinaa@gmail.com>
BCKSELFDRIVEWORLD
pushed a commit
to BCKSELFDRIVEWORLD/navigation2
that referenced
this pull request
Sep 23, 2025
…5427) * Make pause resume controller use nav2::LifecycleNode Signed-off-by: redvinaa <redvinaa@gmail.com> * Fix tests Signed-off-by: redvinaa <redvinaa@gmail.com> * Use new nav2 create_service Signed-off-by: redvinaa <redvinaa@gmail.com> * Use attribues from parent, fix future wait, update docstring Signed-off-by: redvinaa <redvinaa@gmail.com> --------- Signed-off-by: redvinaa <redvinaa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5247 (comment)