fix: add missing keepout and speed zone substitutions for non-composed nodes#5357
Merged
SteveMacenski merged 2 commits intomainfrom Jul 14, 2025
Merged
fix: add missing keepout and speed zone substitutions for non-composed nodes#5357SteveMacenski merged 2 commits intomainfrom
SteveMacenski merged 2 commits intomainfrom
Conversation
…d nodes Non-composed nodes were missing the yaml substitutions for keepout and speed zones that are present in the component container launch. This was causing parameter type errors when the substitution values weren't being replaced. Added: - use_keepout_zones and use_speed_zones launch arguments - yaml_substitutions dictionary with KEEPOUT_ZONE_ENABLED and SPEED_ZONE_ENABLED - value_rewrites parameter to RewrittenYaml to apply the substitutions Fixes #5356 Co-authored-by: Steve Macenski <SteveMacenski@users.noreply.github.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Member
Author
|
Tested and fixes |
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-composed nodes were missing the yaml substitutions for keepout and speed zones that are present in the component container launch. This was causing parameter type errors when the substitution values weren't being replaced.
Added:
Fixes #5356
Generated with Claude Code