Windows fixes from robostack#5333
Conversation
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Generally looks good, but there are a few places that need adjustments to be accepted
nav2_behavior_tree/test/plugins/condition/test_initial_pose_received.cpp
Outdated
Show resolved
Hide resolved
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
I think remaining are the 2x TODOs, the ODE, Robinhood, and updating the realtime prioritization exception text
|
Seems like the TODOs were not the correct solution to the core problem. There were 2 declared but never defined slots in rviz_plugins. Robostack got around it by just defining 2 blank functions. #4974 deleted the declaration which seems like a better solution. It was just never backported to jazzy. Now it should be linting fixes. |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
| #include "nav2_smac_planner/constants.hpp" | ||
|
|
||
| #ifdef _MSC_VER | ||
| #define SELECTED_UNORDERED_MAP std::unordered_map |
There was a problem hiding this comment.
This is significantly slower than the robin hood hashing that we use in the thirdparty directory. Would a major reduction in performance for windows users really be preferable? I think the print out you showed is mostly warnings which can probably be silenced. We have it in the Nav2 codebase so that can be modified and resolved, no?
|
Also make sure to sign off with DCO |
amcl, behavior_tree, nav2_common, nav2_constrained_smoother, nav2_map_server, nav2_msgs, Signed-off-by: Griffin Tabor <tabor473@gmail.com> replace all uint as unsigned int
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
nav2_behavior_tree, opennav_docking, opennav_docking_bt, nav2_map_server, nav2_mppi_controller, nav2_smac_planner, nav2_waypoint_follder Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
remove unimplemented slots from rviz plugins Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
|
@gftabor could you please reply to #5333 (comment)? Also, it looks like there is some overlap with previously merged PRs #4867, #5679 |
|
I am going to close this since there hasn't been any activity in the past six months. Please feel free to reopen if you would still like this to be merged into main :) |
4 participants
Basic Info
Description of contribution in a few bullet points
Fixes to numerous windows build errors. Robostack has a patch for every single nav2 package fixing it to build on windows. Those are documented here https://github.com/RoboStack/ros-jazzy/tree/main/patch . Predominately made by @traversaro . Actually, building Nav2 from source on Windows requires 15 separate patches being applied.
Other change was running replace all on uint -> unsigned int.
Description of documentation updates required from your changes
Description of how this change was tested
Builds on windows, Nav2 turtlebot demos run.
Future work that may be required in bullet points
For Maintainers:
backport-*.