Merged
Conversation
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
0f62005 to
ec920df
Compare
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
ec920df to
14f2853
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
2 tasks
SteveMacenski
approved these changes
Jul 2, 2025
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
I'm curious - is there a tool for auto-fixing these that I'm not aware of or are you doing these by hand? Wanted to know if I could do it myself quickly instead of calling on you - I feel bad :(
Contributor
Author
|
No worries, Steve :) ament_mypy --config=tools/pyproject.toml |
SakshayMahna
pushed a commit
to SakshayMahna/navigation2
that referenced
this pull request
Jul 6, 2025
* Configured nav2_common to be compatible with ament_mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured nav2_bringup to be compatible with ament_mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured nav2_costmap_2d to be compatible with ament_mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured nav2_docking to be compatible with ament_mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured nav2_lifecycle_manager to be compatible with ament_mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured nav2_map_server to be compatible with ament_mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured nav2_simple_commander to be compatible with ament_mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured nav2_system_tests to be compatible with ament_mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.