Nav2 smac planner minor bugfix

[stevedanomodolor]

---

Basic Info

Info	Please fill out this column
Ticket(s) this addresses	(add tickets here #1)
Primary OS tested on	(Ubuntu, MacOS, Windows)
Robotic platform tested on	(Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software?	(No; Yes and it is marked inline in the code)

---

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Description of how this change was tested

---

Future work that may be required in bullet points

For Maintainers:

• Check that any new parameters added are updated in docs.nav2.org
• Check that any significant change is added to the migration guide
• Check that any new features OR changes to existing behaviors are reflected in the tuning guide
• Check that any new functions have Doxygen added
• Check that any new features have test coverage
• Check that any new plugins is added to the plugins page
• If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

[SteveMacenski]

@stevedanomodolor let me know if/when you want me to review. Linking ticket: #5192

@wang-fire can you review / test to see if this resolves your issue?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ
...r/include/nav2_smac_planner/analytic_expansion.hpp	100.00% <ø> (ø)
nav2_smac_planner/src/analytic_expansion.cpp	90.90% <100.00%> (+2.09%)	⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[stevedanomodolor]

@SteveMacenski pr is ready

[SteveMacenski]

Are you able to show a before-and-after to resolve the issue this introduces (Issue 1 in my recent comment here #5192) or do we need to wait on @wang-fire to test and review

[stevedanomodolor]

Are you able to show a before-and-after to resolve the issue this introduces (Issue 1 in my recent comment here #5192) or do we need to wait on @wang-fire to test and review

I will do it, but would appreciate if @wang-fire can also confirm this also.

[SteveMacenski]

@stevedanomodolor that change pulled in a bunch of other commits that shouldn't be here

[stevedanomodolor]

@stevedanomodolor that change pulled in a bunch of other commits that shouldn't be here

working on rebasing it now.

[stevedanomodolor]

@stevedanomodolor that change pulled in a bunch of other commits that shouldn't be here

fixed

[stevedanomodolor]

Are you able to show a before-and-after to resolve the issue this introduces (Issue 1 in my recent comment here #5192) or do we need to wait on @wang-fire to test and review

tested locally to see if issue 1 still persist and I can't see it after the changes in this pr.
I will show a before after tomorrow morning.