Fix - #4400 keepout speed zones#5129
Conversation
* Add keepout filter launch file * Add keepout navigation parameters * Add keepout warehouse map and yaml files
SteveMacenski
left a comment
There was a problem hiding this comment.
There's some clear overlap with #5125 that I think you and @leander-dsouza should coordinate on! Please look over that PRs review as well for some more hints. There's alot of duplication in this PR with new launch files, config files, etc that I think we should be integrating and not replacing with to add these features!
| @@ -0,0 +1,16 @@ | |||
| costmap_filter_info_server: | |||
There was a problem hiding this comment.
Please add parameters to the main nav2_params.yaml file
There was a problem hiding this comment.
Lets do the depot first since that's the default bringup
@rohinraj, Please feel free to have a look over at the PR #5125 to check if I have missed any crucial behaviour. Currently, it only has the keepout filter regions. I plan to add the speed limit regions in a future PR. |
|
Thanks for the contribution @rohinraj but I'm going to close in favor of @leander-dsouz's implementation since they're responding to reviews and we've gone through several design processes already. Thanks for the help and I look forward to your contribution in other potential fixes in the future! |
|
Sure, Thanks. |
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers: