deprecating C API for TF2 and fixing test failures #4823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Macenski <[email protected]>
This was referenced Jan 4, 2025
Merged
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
pepisg
added a commit
to kiwicampus/navigation2
that referenced
this pull request
Jan 8, 2025
…ation#4823)" This reverts commit 4e5d2df.
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
* deprecating C API for TF2 and fixing test failures Signed-off-by: Steve Macenski <[email protected]> * Update costmap_2d_ros.cpp Signed-off-by: Steve Macenski <[email protected]> * Update 2d_utils_test.cpp Signed-off-by: Steve Macenski <[email protected]> * fix remaining issue Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: stevedanomodolor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4732
There's an issue still yet where an erroneous collision is being detected in the rotation shim controller, but the other errors are handled. It was fixed temporarily by moving the origin of the costmap to-2.5, -2.5for a 5x5m window, but caused other tests that rely on that default to fail. I need to investigate why this is failing now and if only moving the origin is the right choice.Fully resolved :-)