Fix goal updater for CI (backport #4558)#4784
Merged
SteveMacenski merged 2 commits intojazzyfrom Feb 4, 2025
Merged
Conversation
Contributor
Author
Contributor
|
This theoretically should not be needed if #4567 can now be done. However I see that a fix has been merged but it seems to specifically target the EventsExecutor, which is not used in Nav2 (and the ticket is not closed)., so can the workaround be reverted or not yet? If not then I would merge that in in the meantime |
Member
|
We can merge this here, happy to do it, but please comment in that rclcpp ticket and still-open PR to ping the folks involved that this is still a problem and still important in jazzy. Once you do that, I can merge this one as a stop-gap |
Member
|
@tonynajjar can you comment on the ticket and link it back here so I can merge this? |
SteveMacenski
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4558 done by [Mergify](https://mergify.com).