Added collision detection for docking (backport #4752)#4758
Merged
SteveMacenski merged 1 commit intojazzyfrom Nov 21, 2024
Merged
Added collision detection for docking (backport #4752)#4758SteveMacenski merged 1 commit intojazzyfrom
SteveMacenski merged 1 commit intojazzyfrom
Conversation
* Added collision detection for docking Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve collision while undocking and test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix smoke testing Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Rename dock_collision_threshold Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added docs and params Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor changes in README Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com> (cherry picked from commit 90a6c8d)
Contributor
Author
SteveMacenski
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers:
This is an automatic backport of pull request #4752 done by [Mergify](https://mergify.com).