Remove nav2_loopback_sim dependency on transforms3d. (backport #4738)#4740
Merged
SteveMacenski merged 1 commit intojazzyfrom Nov 4, 2024
Merged
Remove nav2_loopback_sim dependency on transforms3d. (backport #4738)#4740SteveMacenski merged 1 commit intojazzyfrom
SteveMacenski merged 1 commit intojazzyfrom
Conversation
The package never uses it, so don't declare it. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit a64dde1)
Contributor
Author
SteveMacenski
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
The package never uses it, so don't declare it.
I noticed this because I noticed that recent builds of Navigation2 on Jazzy don't work on RHEL anymore, i.e. https://build.ros2.org/job/Jsrc_el9__navigation2__rhel_9__source/ is disabled. The reason for that is that
python3-transforms3dis not packaged on RHEL-9. However, it turns out that this package doesn't actually usetransforms3d, so the easiest thing to do here is to remove the dependency.Note that if accepted, this should also be backported to the
jazzybranch, and a new bloom-release should be done on the buildfarm for Jazzy.Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
Backport to the
jazzybranch.For Maintainers:
This is an automatic backport of pull request Remove nav2_loopback_sim dependency on transforms3d. #4738 done by Mergify.