Various small CMake fixes.#4643
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Aug 23, 2024
Merged
Conversation
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
| cmake_minimum_required(VERSION 3.5) | ||
| project(nav2_smac_planner) | ||
|
|
||
| set(CMAKE_BUILD_TYPE Release) #Debug, Release |
Member
There was a problem hiding this comment.
We need this for the optimization that it provides, this package in particular is release-necessity for good performance
Contributor
Author
There was a problem hiding this comment.
Yes, but I believe that nav2_common already does this, in a nicer way:
navigation2/nav2_common/cmake/nav2_package.cmake
Lines 21 to 28 in 6bf9d68
Member
There was a problem hiding this comment.
I think about it a bit differently, but perhaps you're right I shouldn't make multiple gates for folks to get through and know about to compile with debug if they want to
josephduchesne
pushed a commit
to josephduchesne/navigation2
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Joseph Duchesne <josephgeek@gmail.com>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Just some minor fixes to various CMake problems found throughout the repository as I was reviewing things in following up for #4357.
Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
None needed.
For Maintainers: