Switch nav2_system_tests to modern CMake idioms.#4638
Conversation
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
I should also mention; with this in, my compile time savings locally is about 1 minute. This is substantially less than I originally saw in #4357; I suspect that there is some other bug on the I'm also going to close #4357 at this point, as with this PR we accomplish everything that one set out to, and more. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
|
I also noticed that the WPF wasn't updated https://github.com/ros-navigation/navigation2/blob/main/nav2_waypoint_follower/CMakeLists.txt - I don't think that's probably the difference maker in compile times, but would you mind doing the last one so they're all homogeneous? |
Yeah, that's one of the last 2 PRs I have (the other is just some minor cleanup here and there). I left it to last because it also requires an update to |
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Joseph Duchesne <josephgeek@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
Basic Info
Description of contribution in a few bullet points
Update nav2_system_tests to use modern CMake idioms:
test_depend, since this is all tests.Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
This is part of a larger series updating Navigation2 to use modern CMake idioms. After this PR, there are 2 PRs left to open.
For Maintainers: