Switch dwb_critics to modern CMake idioms.#4611
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Aug 9, 2024
Merged
Switch dwb_critics to modern CMake idioms.#4611SteveMacenski merged 1 commit intoros-navigation:mainfrom
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Conversation
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
SteveMacenski
approved these changes
Aug 9, 2024
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Looks good to me, but rerunning CI. It failed on a test I've never seen fail before
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
josephduchesne
pushed a commit
to josephduchesne/navigation2
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Joseph Duchesne <josephgeek@gmail.com>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Update dwb_critics to use modern CMake idioms:
Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
This is part of a larger series updating Navigation2 to modern CMake idioms. There are approximately 6 packages left after this one. However, note that I will be taking a break from this work for one or two weeks, as I am on vacation, and still need to do the conversion for 4 more of the packages.
For Maintainers: