Switch nav2_rviz_plugins to modern CMake idioms.#4600
Merged
SteveMacenski merged 2 commits intoros-navigation:mainfrom Aug 7, 2024
Merged
Switch nav2_rviz_plugins to modern CMake idioms.#4600SteveMacenski merged 2 commits intoros-navigation:mainfrom
SteveMacenski merged 2 commits intoros-navigation:mainfrom
Conversation
In addition, make some fixes to the code to more appropriately hold on to the Node object (there were warnings from the compiler without these fixes). Signed-off-by: Chris Lalancette <clalancette@gmail.com>
SteveMacenski
approved these changes
Aug 6, 2024
| auto node = getDisplayContext()->getRosNodeAbstraction().lock()->get_raw_node(); | ||
| node_ptr_ = getDisplayContext()->getRosNodeAbstraction().lock(); | ||
| if (node_ptr_ == nullptr) { | ||
| // The node no longer exists, so just don't initialize |
Member
There was a problem hiding this comment.
For all: Some kind of log, even if cout, that this is the case would be nice (for all instances)
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
SteveMacenski
approved these changes
Aug 7, 2024
josephduchesne
pushed a commit
to josephduchesne/navigation2
that referenced
this pull request
Dec 10, 2024
* Switch nav2_rviz_plugins to modern CMake idioms. In addition, make some fixes to the code to more appropriately hold on to the Node object (there were warnings from the compiler without these fixes). Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Feedback from review. Signed-off-by: Chris Lalancette <clalancette@gmail.com> --------- Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Joseph Duchesne <josephgeek@gmail.com>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
* Switch nav2_rviz_plugins to modern CMake idioms. In addition, make some fixes to the code to more appropriately hold on to the Node object (there were warnings from the compiler without these fixes). Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Feedback from review. Signed-off-by: Chris Lalancette <clalancette@gmail.com> --------- Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition, make some fixes to the code to more appropriately hold on to the Node object (there were warnings from the compiler without these fixes).
Basic Info
Description of contribution in a few bullet points
Change nav2_rviz_plugins to use modern CMake idioms:
Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
This is part of a larger series to switch Navigation2 to use modern CMake idioms. There will be follow-up PRs converting more of the packages.
For Maintainers: