Skip to content

Comments

Switch nav2_navfn_planner to modern CMake idioms.#4591

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
clalancette:clalancette/main-nav2-navfn-planner
Aug 2, 2024
Merged

Switch nav2_navfn_planner to modern CMake idioms.#4591
SteveMacenski merged 1 commit intoros-navigation:mainfrom
clalancette:clalancette/main-nav2-navfn-planner

Conversation

@clalancette
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses Follow-up to #4357
Primary OS tested on Ubuntu 24.04
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Change nav2_navfn_planner to use modern CMake idioms:

  1. Switch from ament_target_dependences() to target_link_libraries()
  2. Push the include directories down one level, which is best practice since Humble.
  3. Make sure to export the target so that downstream users can use the library.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

This is part of a larger series changing Navigation2 to use modern CMake idioms. There will be follow-up PRs to convert other packages.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@SteveMacenski SteveMacenski merged commit 76f9572 into ros-navigation:main Aug 2, 2024
@clalancette clalancette deleted the clalancette/main-nav2-navfn-planner branch August 2, 2024 22:36
josephduchesne pushed a commit to josephduchesne/navigation2 that referenced this pull request Dec 10, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Joseph Duchesne <josephgeek@gmail.com>
stevedanomodolor pushed a commit to stevedanomodolor/navigation2 that referenced this pull request Apr 29, 2025
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants