Switch nav2_mppi_controller to modern CMake idioms.#4590
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Aug 2, 2024
Merged
Conversation
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Member
|
Do you have a list you're working off of? Might be nice to track status in the ticket so we know what's done / coming I really appreciate your work here. What are the compiling times down to now? MPPI and the behavior tree packages were two of the longest packages |
Contributor
Author
We are pretty far along. I'll put a comment in the other ticket, but the packages that are left are:
Right now, we are saving about 30 seconds from before my work. I expect to get a bit more than that, particular when we reach nav2_system_tests, but we'll see as we get there. |
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Change nav2_mppi_controller to use modern CMake idioms:
Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
This is part of a larger series of PRs to switch Navigation2 to modern CMake idioms. There will be follow-up PRs converting more of the packages.
For Maintainers: