Skip to content

Comments

Switch nav2_lifecycle_manager to modern CMake idioms.#4588

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
clalancette:clalancette/main-nav2-lifecycle-manager
Aug 1, 2024
Merged

Switch nav2_lifecycle_manager to modern CMake idioms.#4588
SteveMacenski merged 1 commit intoros-navigation:mainfrom
clalancette:clalancette/main-nav2-lifecycle-manager

Conversation

@clalancette
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses Follow-up to #4357
Primary OS tested on Ubuntu 24.04
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Change nav2_lifecycle_manager to modern CMake idioms:

  1. Change from ament_target_dependencies() to target_link_libraries().
  2. Export the target so that downstream packages can make use of it.
  3. Move the include directory down one directory, which has been best practice since Humble.
  4. Cleanup the dependencies to more accurately reflect what this package needs.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

This is part of a larger series of PRs to update Navigation2 to modern CMake idioms. There will be follow-up PRs to convert more of the packages to this style.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@codecov
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...lifecycle_manager/src/lifecycle_manager_client.cpp 87.80% <ø> (ø)

@SteveMacenski SteveMacenski merged commit a366ca2 into ros-navigation:main Aug 1, 2024
@clalancette clalancette deleted the clalancette/main-nav2-lifecycle-manager branch August 1, 2024 21:01
stevedanomodolor pushed a commit to stevedanomodolor/navigation2 that referenced this pull request Apr 29, 2025
…#4588)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants