Call gz sim directly without shell=True for a clean exit#4456
Closed
azeey wants to merge 3 commits intoros-navigation:mainfrom
Closed
Call gz sim directly without shell=True for a clean exit#4456azeey wants to merge 3 commits intoros-navigation:mainfrom
gz sim directly without shell=True for a clean exit#4456azeey wants to merge 3 commits intoros-navigation:mainfrom
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Member
|
Testing this right now with the full suite of tests and working well. I think we'll keep the python3 util in place so that optionality exists (its still generally useful, even outside of GZ, to bring down zombies) Closing, new PR with the full suite ready. Thanks for the help @azeey! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
ExecuteProcesswithshell=Truegets incorrect exit code from the executed process ros2/launch#757 where the SIGINT signal doesn't propagate to Gazebo whenshell=True. A simple fix is to execute gz-sim directly instead of using the launch files from ros_gz.TODO:
If we're okay with this chance, I can update the rest of the launch files.For Maintainers: