Skip to content

Comments

[amcl] check the recieved initialpose in the size of map#4416

Merged
SteveMacenski merged 10 commits intoros-navigation:mainfrom
GoesM:main
Jun 11, 2024
Merged

[amcl] check the recieved initialpose in the size of map#4416
SteveMacenski merged 10 commits intoros-navigation:mainfrom
GoesM:main

Conversation

@GoesM
Copy link
Contributor

@GoesM GoesM commented Jun 11, 2024

Basic Info

Info Please fill out this column
Ticket(s) this addresses #4307
Primary OS tested on Ubuntu
Robotic platform tested on gazebo simulation
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

main change:

  • check the received initial pose is in the size of map

  • by the way, I noticed that here's one line of redundant code, so I remove it.

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

GoesM added 6 commits June 11, 2024 16:50
reorder pointers-reset & remove rebundant code
87303bf 
Signed-off-by: GoesM <GoesM@buaa.edu.cn>
check the initialpose in map
fc3654e 
Signed-off-by: GoesM <GoesM@buaa.edu.cn>
back
0a59133 
Signed-off-by: GoesM <GoesM@buaa.edu.cn>
remove the redunbant code
5d656d3 
Signed-off-by: GoesM <GoesM@buaa.edu.cn>
code style
15991cd 
Signed-off-by: GoesM <GoesM@buaa.edu.cn>
code style
83689fb 
Signed-off-by: GoesM <GoesM@buaa.edu.cn>
@GoesM GoesM mentioned this pull request Jun 11, 2024
Closed
GoesM added 2 commits June 11, 2024 23:29
code style
6b80840 
Signed-off-by: GoesM <GoesM@buaa.edu.cn>
codestyle
6ec2fd5 
Signed-off-by: GoesM <GoesM@buaa.edu.cn>
SteveMacenski
SteveMacenski approved these changes Jun 11, 2024
View reviewed changes
@SteveMacenski
Update nav2_amcl/src/amcl_node.cpp
6fd8bd6 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
Update nav2_amcl/src/amcl_node.cpp
4d5ddc4 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski SteveMacenski merged commit e8adc71 into ros-navigation:main Jun 11, 2024
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
@GoesM @SteveMacenski @Marc-Morcos
[amcl] check the recieved initialpose in the size of map (ros-navigat…
1560a05 
…ion#4416)

* reorder pointers-reset & remove rebundant code

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* check the initialpose in map

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* back

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* remove the redunbant code

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* codestyle

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* Update nav2_amcl/src/amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_amcl/src/amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: GoesM <GoesM@buaa.edu.cn>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: GoesM <GoesM@buaa.edu.cn>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
@GoesM @SteveMacenski @Marc-Morcos
[amcl] check the recieved initialpose in the size of map (ros-navigat…
f192a30 
…ion#4416)

* reorder pointers-reset & remove rebundant code

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* check the initialpose in map

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* back

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* remove the redunbant code

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* codestyle

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* Update nav2_amcl/src/amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_amcl/src/amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: GoesM <GoesM@buaa.edu.cn>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: GoesM <GoesM@buaa.edu.cn>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski SteveMacenski mentioned this pull request Jul 15, 2024
Closed
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
@GoesM @SteveMacenski @Manos-G
[amcl] check the recieved initialpose in the size of map (ros-navigat…
79cb025 
…ion#4416)

* reorder pointers-reset & remove rebundant code

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* check the initialpose in map

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* back

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* remove the redunbant code

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* codestyle

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* Update nav2_amcl/src/amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_amcl/src/amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: GoesM <GoesM@buaa.edu.cn>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: GoesM <GoesM@buaa.edu.cn>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
stevedanomodolor pushed a commit to stevedanomodolor/navigation2 that referenced this pull request Apr 29, 2025
@GoesM @SteveMacenski @stevedanomodolor
[amcl] check the recieved initialpose in the size of map (ros-navigat…
86e27a6 
…ion#4416)

* reorder pointers-reset & remove rebundant code

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* check the initialpose in map

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* back

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* remove the redunbant code

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* code style

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* codestyle

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* Update nav2_amcl/src/amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_amcl/src/amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: GoesM <GoesM@buaa.edu.cn>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: GoesM <GoesM@buaa.edu.cn>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GoesM @SteveMacenski