fix the bug (similar with #3972) in humble fork #3999
Closed
GoesM wants to merge 2 commits intoros-navigation:humblefrom
GoesM:humble
Closed
fix the bug (similar with #3972) in humble fork #3999GoesM wants to merge 2 commits intoros-navigation:humblefrom GoesM:humble
GoesM wants to merge 2 commits intoros-navigation:humblefrom
GoesM:humble
Conversation
Contributor
SteveMacenski
requested changes
Dec 4, 2023
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Please directly cherry-pick the other PR, do not just modify a few lines
| * Costmap2DROS may be launched by another Lifecycle Node as a composed module | ||
| * If composed, its parents will handle the shutdown, which includes this module | ||
| */ | ||
| void on_rcl_preshutdown() override |
Member
There was a problem hiding this comment.
You did not modify the constructor for setting this to false.
Contributor
Author
There was a problem hiding this comment.
Do you mean we should modify the constructor in humble to look like in main branch?
Member
There was a problem hiding this comment.
I'm saying that you should directly git cherry-pick the main commit to the humble branch and push that to this PR 😄 That way they're exactly the same. In fact, it might be wise to close this PR in general and reopen one with only the cherry picked commit.
Otherwise, if you wait like ~3 weeks, I'll be running a Humble sync and I'll get to this myself 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
it seems that bug fix work in #3972 has not been pulled into fork nav2-humble.
Here's our modified humble-fork born from our previous work process.
Perhaps these ready-made commits would do help for you ^_^