Publish collision monitor state#3504
Merged
AlexeyMerzlyakov merged 18 commits intoros-navigation:mainfrom Mar 28, 2023
Merged
Conversation
SteveMacenski
requested changes
Mar 23, 2023
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Looks good in general, most are nit picks and a couple of questions
nav2_collision_monitor/include/nav2_collision_monitor/types.hpp
Outdated
Show resolved
Hide resolved
nav2_collision_monitor/include/nav2_collision_monitor/types.hpp
Outdated
Show resolved
Hide resolved
SteveMacenski
requested changes
Mar 24, 2023
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Otherwise LGTM, just need the complimentary documentation updates for the new parameter in the config guide + migration guide for the new feature
Contributor
Author
|
Thanks for the review @SteveMacenski and @AlexeyMerzlyakov! Created a PR for updating the config guide + migration guide too. |
SteveMacenski
approved these changes
Mar 27, 2023
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
LGTM. On Alexey's final call to merge.
7 tasks
AlexeyMerzlyakov
approved these changes
Mar 28, 2023
Collaborator
AlexeyMerzlyakov
left a comment
There was a problem hiding this comment.
Change reviewed: OK.
Local colcon test --packages-select nav2_collision_monitor: OK
Codecov test: OK
Local TB3 simulation verification: OK (CM is working well and publishing a new topic)
kaichie
added a commit
to botsandus/navigation2
that referenced
this pull request
Mar 28, 2023
kaichie
added a commit
to botsandus/navigation2
that referenced
this pull request
Apr 21, 2023
gennartan
pushed a commit
to gennartan/navigation2
that referenced
this pull request
Jan 17, 2024
This commits is cherry-picked from b8d077e. The collision monitor now has an additional parameter named "state_topic". If the state topic is set, the collision monitor will publish its status to the defined topic so that other nodes might perform actions based on the current state of the collision monitor.
7 tasks
gennartan
pushed a commit
to gennartan/navigation2
that referenced
this pull request
Jan 17, 2024
This commits is cherry-picked from b8d077e. The collision monitor now has an additional parameter named "state_topic". If the state topic is set, the collision monitor will publish its status to the defined topic so that other nodes might perform actions based on the current state of the collision monitor. Signed-off-by: agennart <antoine.gennart@quimesis.be>
jncfa
pushed a commit
to jncfa/navigation2
that referenced
this pull request
Sep 26, 2025
This was referenced Sep 26, 2025
jncfa
pushed a commit
to jncfa/navigation2
that referenced
this pull request
Sep 26, 2025
Signed-off-by: jncfa <20467009+jncfa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
nav2_msgs-CollisionMonitorState.msgDO_NOTHINGpolygon_nameinstead ofaction_type(To handle multipleslowdownpolygons correctly)Description of documentation updates required from your changes
Future work that may be required in bullet points
cmd_vel, but I think it will be very useful to publish the polygon state even when the robot is not moving too. Especially for cases like when thestoppolygon is triggered(regardless ofcmd_velspeed), or when there are points inapproachpolygon where the robot will not be able to move. (Probably similar requirement as mentioned here)For Maintainers: