Skip to content

Fix error code test#3321

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
jwallace42:error_code_test_fix
Dec 10, 2022
Merged

Fix error code test#3321
SteveMacenski merged 1 commit intoros-navigation:mainfrom
jwallace42:error_code_test_fix

Conversation

@jwallace42
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Check that the node is active before making a action request though the python api.

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2022

@jwallace42, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski marked this pull request as ready for review December 10, 2022 21:05
@SteveMacenski SteveMacenski merged commit 7556d1b into ros-navigation:main Dec 10, 2022
jwallace42 added a commit to jwallace42/navigation2 that referenced this pull request Dec 14, 2022
Co-authored-by: Joshua Wallace <josho.wallace.com>
andrewlycas pushed a commit to StratomInc/navigation2 that referenced this pull request Feb 23, 2023
Co-authored-by: Joshua Wallace <josho.wallace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants