Skip to content

Draft: Added GoalUpdatedController BT plugin node (backport #3044)#3057

Closed
mergify[bot] wants to merge 1 commit intogalacticfrom
mergify/bp/galactic/pr-3044
Closed

Draft: Added GoalUpdatedController BT plugin node (backport #3044)#3057
mergify[bot] wants to merge 1 commit intogalacticfrom
mergify/bp/galactic/pr-3044

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 1, 2022

This is an automatic backport of pull request #3044 done by Mergify.
Cherry-pick of 28d16ab has failed:

On branch mergify/bp/galactic/pr-3044
Your branch is up to date with 'origin/galactic'.

You are currently cherry-picking commit 28d16ab5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   nav2_behavior_tree/CMakeLists.txt
	new file:   nav2_behavior_tree/include/nav2_behavior_tree/plugins/decorator/goal_updated_controller.hpp
	new file:   nav2_behavior_tree/plugins/decorator/goal_updated_controller.cpp
	new file:   nav2_behavior_tree/test/plugins/decorator/test_goal_updated_controller.cpp
	modified:   nav2_bringup/bringup/params/nav2_multirobot_params_1.yaml
	modified:   nav2_bringup/bringup/params/nav2_multirobot_params_2.yaml
	modified:   nav2_bringup/bringup/params/nav2_params.yaml
	new file:   nav2_bt_navigator/behavior_trees/navigate_w_replanning_only_if_goal_is_updated.xml
	modified:   nav2_bt_navigator/src/bt_navigator.cpp
	modified:   nav2_system_tests/src/costmap_filters/keepout_params.yaml
	modified:   nav2_system_tests/src/costmap_filters/speed_global_params.yaml
	modified:   nav2_system_tests/src/costmap_filters/speed_local_params.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   nav2_behavior_tree/nav2_tree_nodes.xml
	both modified:   nav2_behavior_tree/test/plugins/decorator/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* first draft for goal updated controller

Signed-off-by: relffok <57466265+relffok@users.noreply.github.com>

* added goal_updated_controller to all yamls

* added GoalUpdatedController API

* added GoaUpdatedController to default plugins

* removed first_time param

* added test for GoalUpdatedController

* linter fix

(cherry picked from commit 28d16ab)

# Conflicts:
#	nav2_behavior_tree/nav2_tree_nodes.xml
#	nav2_behavior_tree/test/plugins/decorator/CMakeLists.txt
@mergify mergify bot added the conflicts label Jul 1, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Jul 1, 2022

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @galactic, but it must be in main
to have these changes reflected into new distributions.

@mergify
Copy link
Contributor Author

mergify bot commented Jul 1, 2022

@mergify[bot], please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski deleted the mergify/bp/galactic/pr-3044 branch July 1, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants