main branch adding odom topic passed to odom smoother#2800
Closed
bot-lin wants to merge 1 commit intoros-navigation:mainfrom
bot-lin:bot-lin-main-pr
Closed
main branch adding odom topic passed to odom smoother#2800bot-lin wants to merge 1 commit intoros-navigation:mainfrom bot-lin:bot-lin-main-pr
bot-lin wants to merge 1 commit intoros-navigation:mainfrom
bot-lin:bot-lin-main-pr
Conversation
Contributor
|
@bot-lin, please properly fill in PR template in the future. @SteveMacenski, use this instead.
|
SteveMacenski
approved these changes
Feb 4, 2022
Member
|
Just waiting on CI and I'll merge the pair |
Member
|
All of the system tests failed and I can say honestly I have no idea why. I'm re-running CI to see if it was just a fluke |
Member
|
@bot-lin please rebase your PR on main's current state (or pull it in), the PR appears to be failing due to a caching issue with missing a message that was recently added |
Member
|
#2822 supersedes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Passed odom topic from bt_navigator to odom smoother
Description of documentation updates required from your changes
bt_navigator can now subscribe to specified odom topic.
For Maintainers: