Skip to content

main branch adding odom topic passed to odom smoother#2800

Closed
bot-lin wants to merge 1 commit intoros-navigation:mainfrom
bot-lin:bot-lin-main-pr
Closed

main branch adding odom topic passed to odom smoother#2800
bot-lin wants to merge 1 commit intoros-navigation:mainfrom
bot-lin:bot-lin-main-pr

Conversation

@bot-lin
Copy link

@bot-lin bot-lin commented Feb 4, 2022


Basic Info

Info Please fill out this column
Ticket(s) this addresses #2785
Primary OS tested on Ubuntu 20.04
Robotic platform tested on gazebo simulation

Description of contribution in a few bullet points

Passed odom topic from bt_navigator to odom smoother

Description of documentation updates required from your changes

bt_navigator can now subscribe to specified odom topic.


For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2022

@bot-lin, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski
Copy link
Member

Just waiting on CI and I'll merge the pair

@SteveMacenski
Copy link
Member

All of the system tests failed and I can say honestly I have no idea why. I'm re-running CI to see if it was just a fluke

@SteveMacenski
Copy link
Member

@bot-lin please rebase your PR on main's current state (or pull it in), the PR appears to be failing due to a caching issue with missing a message that was recently added

@padhupradheep padhupradheep mentioned this pull request Feb 15, 2022
7 tasks
@SteveMacenski
Copy link
Member

#2822 supersedes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants