Skip to content

Adding odom topic passed to Odom Smoother#2795

Closed
bot-lin wants to merge 1 commit intoros-navigation:galacticfrom
bot-lin:bot-lin
Closed

Adding odom topic passed to Odom Smoother#2795
bot-lin wants to merge 1 commit intoros-navigation:galacticfrom
bot-lin:bot-lin

Conversation

@bot-lin
Copy link

@bot-lin bot-lin commented Feb 1, 2022


Basic Info

Info Please fill out this column
Ticket(s) this addresses #2785
Primary OS tested on Ubuntu 20.04
Robotic platform tested on gazebo simulation

Description of contribution in a few bullet points

  • Passed odom topic from bt_navigator to odom smoother

Description of documentation updates required from your changes

  • bt_navigator can now subscribe to specified odom topic.

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

@bot-lin, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @galactic, but it must be in main
to have these changes reflected into new distributions.

@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

@bot-lin, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but we need a PR against main so that all new distributions will have this change reflected in it. Galactic branch will only reflect Galactic developers. Please submit this PR against the main branch, its a trivial number of changes so it should be easy to checkout the main branch and add them by hand and submit a new branch as a PR

@SteveMacenski
Copy link
Member

#2822 supersedes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants