Improve interface of NavigateToPose#1880
Improve interface of NavigateToPose#1880SteveMacenski merged 4 commits intoros-navigation:masterfrom
Conversation
Signed-off-by: ymd-stella <world.applepie@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
==========================================
- Coverage 69.54% 68.74% -0.80%
==========================================
Files 218 218
Lines 10595 10603 +8
==========================================
- Hits 7368 7289 -79
- Misses 3227 3314 +87
Continue to review full report at Codecov.
|
|
@crdelsey @cdelsey can you review this? |
|
I think this change should also be accompanied with a BT conversion function to parse BT XML strings to a |
Signed-off-by: ymd-stella <world.applepie@gmail.com>
|
@naiveHobo you approve? @ymd-stella LGTM, but you need to fix a linting error in the bt conversions file. Run |
|
Waiting on CI |
mkhansenbot
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for looping me in and sorry for the late response
|
@SteveMacenski What is the status of this PR? Is there any task left for me to do? |
|
None, just forgot to mark as "merge" because waiting for CI, thanks for the push |
* Improve interface of NavigateToPose Signed-off-by: ymd-stella <world.applepie@gmail.com> * Update bt_conversions.hpp (PoseStamped) * Use full message of PoseStamped Signed-off-by: ymd-stella <world.applepie@gmail.com> * Fix lint error
* Improve interface of NavigateToPose Signed-off-by: ymd-stella <world.applepie@gmail.com> * Update bt_conversions.hpp (PoseStamped) * Use full message of PoseStamped Signed-off-by: ymd-stella <world.applepie@gmail.com> * Fix lint error
Basic Info
Description of contribution in a few bullet points
Future work that may be required in bullet points