Skip to content

Improve interface of NavigateToPose#1880

Merged
SteveMacenski merged 4 commits intoros-navigation:masterfrom
ymd-stella:feat/improve-nav-to-pose
Aug 7, 2020
Merged

Improve interface of NavigateToPose#1880
SteveMacenski merged 4 commits intoros-navigation:masterfrom
ymd-stella:feat/improve-nav-to-pose

Conversation

@ymd-stella
Copy link
Copy Markdown
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses (related to #1796)

Description of contribution in a few bullet points

  • NavigateToPose input has been changed from (Position, Orientation) to Goal to make the goal easier to handle.

Future work that may be required in bullet points

Signed-off-by: ymd-stella <world.applepie@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 19, 2020

Codecov Report

Merging #1880 into master will decrease coverage by 0.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   69.54%   68.74%   -0.80%     
==========================================
  Files         218      218              
  Lines       10595    10603       +8     
==========================================
- Hits         7368     7289      -79     
- Misses       3227     3314      +87     
Impacted Files Coverage Δ
...tree/include/nav2_behavior_tree/bt_conversions.hpp 100.00% <100.00%> (ø)
...or_tree/plugins/action/navigate_to_pose_action.hpp 100.00% <100.00%> (ø)
...or_tree/plugins/action/navigate_to_pose_action.cpp 58.33% <100.00%> (-10.42%) ⬇️
...re/include/dwb_core/illegal_trajectory_tracker.hpp 40.00% <0.00%> (-60.00%) ⬇️
...roller/dwb_core/src/illegal_trajectory_tracker.cpp 25.00% <0.00%> (-55.00%) ⬇️
...ree/include/nav2_behavior_tree/bt_service_node.hpp 86.84% <0.00%> (-13.16%) ⬇️
...tree/include/nav2_behavior_tree/bt_action_node.hpp 79.26% <0.00%> (-12.20%) ⬇️
...map_2d/include/nav2_costmap_2d/inflation_layer.hpp 91.66% <0.00%> (-8.34%) ⬇️
nav2_costmap_2d/src/clear_costmap_service.cpp 17.89% <0.00%> (-6.32%) ⬇️
..._dwb_controller/dwb_core/src/dwb_local_planner.cpp 77.32% <0.00%> (-4.97%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1d8a1...0076233. Read the comment docs.

Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkhansenbot any reason not to do this?

@SteveMacenski
Copy link
Copy Markdown
Member

SteveMacenski commented Jul 20, 2020

@crdelsey @cdelsey can you review this?

@naiveHobo
Copy link
Copy Markdown
Contributor

I think this change should also be accompanied with a BT conversion function to parse BT XML strings to a geometry_msgs/PoseStamped message like it's done here.

Comment thread doc/parameters/param_list.md
Comment thread nav2_behavior_tree/include/nav2_behavior_tree/bt_conversions.hpp
Signed-off-by: ymd-stella <world.applepie@gmail.com>
@SteveMacenski
Copy link
Copy Markdown
Member

@naiveHobo you approve?

@ymd-stella LGTM, but you need to fix a linting error in the bt conversions file. Run ament_cpplint and ament_uncrustify before submitting any PR.

@SteveMacenski
Copy link
Copy Markdown
Member

Waiting on CI

Copy link
Copy Markdown
Collaborator

@mkhansenbot mkhansenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for looping me in and sorry for the late response

@ymd-stella
Copy link
Copy Markdown
Contributor Author

ymd-stella commented Aug 7, 2020

@SteveMacenski What is the status of this PR? Is there any task left for me to do?

@SteveMacenski SteveMacenski merged commit 4376e23 into ros-navigation:master Aug 7, 2020
@SteveMacenski
Copy link
Copy Markdown
Member

None, just forgot to mark as "merge" because waiting for CI, thanks for the push

SteveMacenski pushed a commit that referenced this pull request Aug 11, 2020
* Improve interface of NavigateToPose

Signed-off-by: ymd-stella <world.applepie@gmail.com>

* Update bt_conversions.hpp (PoseStamped)

* Use full message of PoseStamped

Signed-off-by: ymd-stella <world.applepie@gmail.com>

* Fix lint error
ruffsl pushed a commit to ruffsl/navigation2 that referenced this pull request Jul 2, 2021
* Improve interface of NavigateToPose

Signed-off-by: ymd-stella <world.applepie@gmail.com>

* Update bt_conversions.hpp (PoseStamped)

* Use full message of PoseStamped

Signed-off-by: ymd-stella <world.applepie@gmail.com>

* Fix lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants