Issue 1608 segmentation fault planner server node master (#1612)#1767
Merged
SteveMacenski merged 1 commit intoros-navigation:eloquent-develfrom May 27, 2020
blacksoul000:eloquent-devel
Merged
Issue 1608 segmentation fault planner server node master (#1612)#1767SteveMacenski merged 1 commit intoros-navigation:eloquent-develfrom blacksoul000:eloquent-devel
SteveMacenski merged 1 commit intoros-navigation:eloquent-develfrom
blacksoul000:eloquent-devel
Conversation
* corrected wrong indexing in NavfnPlanner::smoothApproachToGoal function * resolved uncrustify errors * corrected the condition inside NavfnPlanner::smoothApproachToGoal to replace last pose of computed path Co-authored-by: chikmagalore.thilak <chikmagalore.thilak@bshg.com>
Member
|
Retriggering ROS2 CI farm. There'sa couple of test failures I want to check on. |
SteveMacenski
approved these changes
May 26, 2020
Member
|
This PR is causing a number of failures in the build farm that aren't usual |
Member
|
A new run seems to have fixed it, merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corrected wrong indexing in NavfnPlanner::smoothApproachToGoal function
resolved uncrustify errors
corrected the condition inside NavfnPlanner::smoothApproachToGoal to replace last pose of computed path
Co-authored-by: chikmagalore.thilak chikmagalore.thilak@bshg.com
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points