Feedback in navigation2 actions#1586
Closed
SteveMacenski wants to merge 4 commits intoros-navigation:masterfrom
Closed
Feedback in navigation2 actions#1586SteveMacenski wants to merge 4 commits intoros-navigation:masterfrom
SteveMacenski wants to merge 4 commits intoros-navigation:masterfrom
Conversation
cdelsey
reviewed
Mar 26, 2020
Contributor
cdelsey
left a comment
There was a problem hiding this comment.
This looks good. Thanks for doing this Steve.
Co-Authored-By: Carl Delsey <1828778+cdelsey@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1586 +/- ##
=========================================
+ Coverage 38.21% 38.51% +0.3%
=========================================
Files 229 228 -1
Lines 11924 11976 +52
Branches 5240 5276 +36
=========================================
+ Hits 4557 4613 +56
+ Misses 3883 3836 -47
- Partials 3484 3527 +43
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Added feedback to long running actions.
removed random crawl as it is still in nav2 experimental with the server
NavigateToPose; pose, time spent on task, number of recoveries executed, distance remaining
Follow path: Instantaneous speed, distance to goal in odom
Spin and backup: distance so far gone
Wait and compute path: none, as either has a while loop naturally conducive to feedback.
Description of documentation updates required from your changes
Future work that may be required in bullet points
This PR is also to gather reviews and feedback on other metrics you'd like to have included in the API.