-
Notifications
You must be signed in to change notification settings - Fork 268
Add DWPP Description #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DWPP Description #802
Changes from 11 commits
5b468e1
3fea28a
d7a2abd
aa1ad36
fc06687
ae30eed
7566083
a7ca956
52b2603
494fce8
2cb2c31
f23223a
6299763
84f55aa
f7104a3
153440d
78081ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,7 +122,7 @@ Controllers | |
| | | | holonomic robots. | Differential | | ||
| +--------------------------------+-----------------------+------------------------------------+-----------------------+ | ||
| | `Regulated Pure Pursuit`_ | Steve Macenski | A service / industrial robot | **Ackermann**, Legged,| | ||
| | | | variation on the pure pursuit | Differential | | ||
| | | Fumiya Ohnishi | variation on the pure pursuit | Differential | | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is a bit too much - I appreciate the valuable contribution and I'm sure it'll have alot of great impact, but I think adding another feature to the controller is not quite amounting to prime authorship attribution. I had to think about this for a few minutes, and in all DWB/TEB/MPPI there have been contributions to add new features / capabilities, but we don't reflect all authors in those -- only the main author or team of authors that collaborated in the initial release development. |
||
| | | | algorithm with adaptive features. | | | ||
| +--------------------------------+-----------------------+------------------------------------+-----------------------+ | ||
| | `MPPI Controller`_ | Steve Macenski | A predictive MPC controller with | Differential, Omni, | | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the migration guide, we need to mention this change. I'd also put in the description a note that it is
desired_linear_velin Kilted and older.