Add DWPP Description#802
Conversation
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
| Regulated Pure Pursuit Parameters | ||
| ********************************* | ||
|
|
||
| :desired_linear_vel: |
There was a problem hiding this comment.
In the migration guide, we need to mention this change. I'd also put in the description a note that it is desired_linear_vel in Kilted and older.
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
|
@decwest last updates here are the migration guide entry for this change to add the feature + parameter renaming. This is important for folks to be aware of changes they need to make to their configurations when upgrading distributions and expose that there's this new feature they may want to try out. |
|
@SteveMacenski |
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
|
This one :-) https://docs.nav2.org/migration/Kilted.html |
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
|
@SteveMacenski |
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
plugins/index.rst
Outdated
| +--------------------------------+-----------------------+------------------------------------+-----------------------+ | ||
| | `Regulated Pure Pursuit`_ | Steve Macenski | A service / industrial robot | **Ackermann**, Legged,| | ||
| | | | variation on the pure pursuit | Differential | | ||
| | | Fumiya Ohnishi | variation on the pure pursuit | Differential | |
There was a problem hiding this comment.
I think this is a bit too much - I appreciate the valuable contribution and I'm sure it'll have alot of great impact, but I think adding another feature to the controller is not quite amounting to prime authorship attribution. I had to think about this for a few minutes, and in all DWB/TEB/MPPI there have been contributions to add new features / capabilities, but we don't reflect all authors in those -- only the main author or team of authors that collaborated in the initial release development.
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
|
Thank you for reviewing the documents. I have fixed the merge conflicts and addressed the comments I received. P.S. I am currently preparing a journal paper on DWPP, which includes real-robot experimental results comparing PP, APP, RPP, and DWPP using the Nav2 implementation :) I would like to ask for your advice on one point.
|
There was a problem hiding this comment.
I approve, but the only thing I'd maybe suggest is in the use_dynamic_window parameter description entry, spend a couple of sentences explaining why this is valuable. I want people to look at this and understand why your awesome work might be good for them to enable and configure :-)
I think some brass-tacks concise explanation of what it does and the value would be good for others in the future.
Once merged, it might be good to put https://github.com/Decwest/nav2_dynamic_window_pure_pursuit_controller to a public archive and in the readme point people to Nav2's implementation since that'll be kept up to date from here on out with new features / fixes :-)
Yes, it is realistic. I plan to review your PR again tomorrow.
It depends on the wording, but broadly speaking, yes! :-) |
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
|
@SteveMacenski Also, I will move my DWPP Nav2 plugin repository to a public archive after this is merged! |
Thank you very much for taking the time to review my PR despite your busy schedule. I also sincerely appreciate your permission to mention the Nav2 integration in the paper. I am planning to add the following sentence to the abstract, introduction, and conclusion of the paper:
In addition, of course, I will include an acknowledgment for the Nav2 maintainers. Would this be okay with you? |
|
Sounds good to me |
Basic Info
Description of contribution in a few bullet points