Skip to content

Add DWPP Description#802

Merged
SteveMacenski merged 17 commits intoros-navigation:masterfrom
decwest:feature/integrate_dwpp
Jan 20, 2026
Merged

Add DWPP Description#802
SteveMacenski merged 17 commits intoros-navigation:masterfrom
decwest:feature/integrate_dwpp

Conversation

@decwest
Copy link
Contributor

@decwest decwest commented Oct 30, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses ros-navigation/navigation2#5591
Does this PR contain AI-generated software? No

Description of contribution in a few bullet points

  • Updated the documentation to reflect implenmentation of DWPP in navigation2.
  • Added descriptions of the parameters introduced for the DWPP implementation.

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Regulated Pure Pursuit Parameters
*********************************

:desired_linear_vel:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the migration guide, we need to mention this change. I'd also put in the description a note that it is desired_linear_vel in Kilted and older.

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
@SteveMacenski
Copy link
Member

@decwest last updates here are the migration guide entry for this change to add the feature + parameter renaming. This is important for folks to be aware of changes they need to make to their configurations when upgrading distributions and expose that there's this new feature they may want to try out.

@decwest
Copy link
Contributor Author

decwest commented Dec 14, 2025

@SteveMacenski
Understood. I’ll work on it.
Could you please let me know which file in the Migration Guide I should update?

https://docs.nav2.org/migration/index.html

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
@SteveMacenski
Copy link
Member

This one :-) https://docs.nav2.org/migration/Kilted.html

@decwest
Copy link
Contributor Author

decwest commented Dec 20, 2025

@SteveMacenski
I updated the migration guide :)

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just reduced the migration guide bit to be more concise, this should be an overview not a detailed blow by blow

Please also fix the merge conflicts

+--------------------------------+-----------------------+------------------------------------+-----------------------+
| `Regulated Pure Pursuit`_ | Steve Macenski | A service / industrial robot | **Ackermann**, Legged,|
| | | variation on the pure pursuit | Differential |
| | Fumiya Ohnishi | variation on the pure pursuit | Differential |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bit too much - I appreciate the valuable contribution and I'm sure it'll have alot of great impact, but I think adding another feature to the controller is not quite amounting to prime authorship attribution. I had to think about this for a few minutes, and in all DWB/TEB/MPPI there have been contributions to add new features / capabilities, but we don't reflect all authors in those -- only the main author or team of authors that collaborated in the initial release development.

decwest and others added 5 commits January 3, 2026 20:11
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
@decwest
Copy link
Contributor Author

decwest commented Jan 3, 2026

@SteveMacenski @mini-1235

Thank you for reviewing the documents.

I have fixed the merge conflicts and addressed the comments I received.
I would appreciate it if you could take a look when you have some time.

P.S. I am currently preparing a journal paper on DWPP, which includes real-robot experimental results comparing PP, APP, RPP, and DWPP using the Nav2 implementation :)
The submission deadline is January 21, so I am planning to upload a preprint to arXiv toward the end of this month and include the link in this document as well.

I would like to ask for your advice on one point.
Do you think it is realistic to have DWPP merged into the main branch by January 21?
If integration is possible, would it be acceptable to include a statement such as the following in the journal paper to highlight that DWPP has been integrated into Nav2?

The proposed method is integrated into the official Nav2 repository and is publicly available.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but the only thing I'd maybe suggest is in the use_dynamic_window parameter description entry, spend a couple of sentences explaining why this is valuable. I want people to look at this and understand why your awesome work might be good for them to enable and configure :-)

I think some brass-tacks concise explanation of what it does and the value would be good for others in the future.

Once merged, it might be good to put https://github.com/Decwest/nav2_dynamic_window_pure_pursuit_controller to a public archive and in the readme point people to Nav2's implementation since that'll be kept up to date from here on out with new features / fixes :-)

@SteveMacenski
Copy link
Member

SteveMacenski commented Jan 13, 2026

Do you think it is realistic to have DWPP merged into the main branch by January 21?

Yes, it is realistic. I plan to review your PR again tomorrow.

If integration is possible, would it be acceptable to include a statement such as the following in the journal paper to highlight that DWPP has been integrated into Nav2?

It depends on the wording, but broadly speaking, yes! :-)

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
@decwest
Copy link
Contributor Author

decwest commented Jan 13, 2026

@SteveMacenski
Thank you for checking.
I added a concise explanation of the function and its value to the use_dynamic_window description entry.

Whether to use the Dynamic Window Pure Pursuit (DWPP) Algorithm. This algorithm computes command velocities that track the path as accurately as possible while respecting velocity and acceleration constraints. It automatically slows down in sharp turns without manual tuning, reducing path tracking errors.

Also, I will move my DWPP Nav2 plugin repository to a public archive after this is merged!

@decwest
Copy link
Contributor Author

decwest commented Jan 13, 2026

Do you think it is realistic to have DWPP merged into the main branch by January 21?

Yes, it is realistic. I plan to review your PR again tomorrow.

If integration is possible, would it be acceptable to include a statement such as the following in the journal paper to highlight that DWPP has been integrated into Nav2?

It depends on the wording, but broadly speaking, yes! :-)

Thank you very much for taking the time to review my PR despite your busy schedule. I also sincerely appreciate your permission to mention the Nav2 integration in the paper.

I am planning to add the following sentence to the abstract, introduction, and conclusion of the paper:

The proposed method has been integrated into the official Nav2 repository and is publicly available. https://github.com/ros-navigation/navigation2

In addition, of course, I will include an acknowledgment for the Nav2 maintainers.

Would this be okay with you?

@SteveMacenski
Copy link
Member

Sounds good to me

@SteveMacenski SteveMacenski merged commit e762ba0 into ros-navigation:master Jan 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants