Skip to content

Add note on multirobot refactor to migration guide#609

Merged
SteveMacenski merged 12 commits intoros-navigation:masterfrom
luca-della-vedova:luca/multirobot_migration
Dec 3, 2024
Merged

Add note on multirobot refactor to migration guide#609
SteveMacenski merged 12 commits intoros-navigation:masterfrom
luca-della-vedova:luca/multirobot_migration

Conversation

@luca-della-vedova
Copy link
Contributor

Add migration for PR ros-navigation/navigation2#4715

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@SteveMacenski
Copy link
Member

One more thing and this should be done https://docs.nav2.org/tuning/index.html --> remove the use_namespace parameter description if we're removing it

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@luca-della-vedova luca-della-vedova force-pushed the luca/multirobot_migration branch from 315efce to 662efa0 Compare November 25, 2024 06:27
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
luca-della-vedova and others added 2 commits November 26, 2024 19:24
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
Copy link
Member

I fixed some formatting for you, LGTM

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@luca-della-vedova
Copy link
Contributor Author

It shows that I only wrote markdown in my life 😅, noticed that the highlighting of snippets wasn't working because it's supposed to be double backtick so fixed that in 3cc1e2e

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@SteveMacenski
Copy link
Member

Otherwise, I can merge

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@SteveMacenski SteveMacenski merged commit f7e5776 into ros-navigation:master Dec 3, 2024
alexanderjyuen pushed a commit to alexanderjyuen/docs.nav2.org that referenced this pull request Dec 11, 2024
* Add note on multirobot refactor to migration guide

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Add example for configuration of sensor topic

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Add notes to topic configuration guides

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Fix formatting

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Remove use_namespace parameter

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Remove map_topic parameter and add migration note

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Update Jazzy.rst

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Add migration note on Costmap2DROS constructors

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Change all literals to double backtick

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Grammar

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Update default value / remove reference to global param

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

---------

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
alexanderjyuen pushed a commit to alexanderjyuen/docs.nav2.org that referenced this pull request Dec 11, 2024
* Add note on multirobot refactor to migration guide

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Add example for configuration of sensor topic

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Add notes to topic configuration guides

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Fix formatting

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Remove use_namespace parameter

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Remove map_topic parameter and add migration note

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Update Jazzy.rst

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Add migration note on Costmap2DROS constructors

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Change all literals to double backtick

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Grammar

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Update default value / remove reference to global param

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

---------

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
alexanderjyuen pushed a commit to alexanderjyuen/docs.nav2.org that referenced this pull request Dec 11, 2024
* Add note on multirobot refactor to migration guide

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Add example for configuration of sensor topic

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Add notes to topic configuration guides

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Fix formatting

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Remove use_namespace parameter

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Remove map_topic parameter and add migration note

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Update Jazzy.rst

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Add migration note on Costmap2DROS constructors

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Change all literals to double backtick

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Grammar

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Update default value / remove reference to global param

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

---------

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants