Skip to content

Fix compilation warnings #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2023
Merged

Fix compilation warnings #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9350ddd
catch exception by reference
Noel215 May 22, 2023
dcc64a5
Enforce internal linkage for classes in test_gripper_controllers.hpp
mathias-luedtke May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion diff_drive_controller/src/diff_drive_controller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ controller_interface::return_type DiffDriveController::update(
should_publish = true;
}
}
catch (const std::runtime_error)
catch (const std::runtime_error &)
{
// Handle exceptions when the time source changes and initialize publish timestamp
previous_publish_timestamp_ = time;
Expand Down
5 changes: 5 additions & 0 deletions gripper_controllers/test/test_gripper_controllers.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ using hardware_interface::HW_IF_POSITION;
using hardware_interface::HW_IF_VELOCITY;
using hardware_interface::StateInterface;

namespace
{

// subclassing and friending so we can access member variables
class FriendGripperController
: public gripper_action_controller::GripperActionController<HW_IF_POSITION>
Expand Down Expand Up @@ -62,4 +65,6 @@ class GripperControllerTest : public ::testing::Test
CommandInterface joint_1_pos_cmd_{joint_name_, HW_IF_POSITION, &joint_commands_[0]};
};

} // anonymous namespace

#endif // TEST_GRIPPER_CONTROLLERS_HPP_