Skip to content

Conversation

@Noel215
Copy link
Contributor

@Noel215 Noel215 commented May 25, 2023

This pull request fixes the compilation warnings for this repository.

There are more warnings about the usage of deprecated methods but there is already another pull request ( for humble #616) for that.

Noel215 and others added 2 commits May 25, 2023 18:54
@codecov-commenter
Copy link

Codecov Report

Merging #621 (dcc64a5) into master (e7f9962) will increase coverage by 0.20%.
The diff coverage is 33.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
+ Coverage   35.78%   35.98%   +0.20%     
==========================================
  Files         189        7     -182     
  Lines       17570      678   -16892     
  Branches    11592      362   -11230     
==========================================
- Hits         6287      244    -6043     
+ Misses        994      134     -860     
+ Partials    10289      300    -9989     
Flag Coverage Δ
unittests 35.98% <33.82%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 11.11% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 45.76% <45.02%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit 70e282f into ros-controls:master May 25, 2023
@bmagyar
Copy link
Member

bmagyar commented May 25, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 25, 2023
* catch exception by reference

* Enforce internal linkage for classes in test_gripper_controllers.hpp

To avoid problems with HW_IF_POSITION (-Wsubobject-linkage)

---------

Co-authored-by: Mathias Lüdtke <[email protected]>
(cherry picked from commit 70e282f)
bmagyar pushed a commit that referenced this pull request May 25, 2023
* catch exception by reference

* Enforce internal linkage for classes in test_gripper_controllers.hpp

To avoid problems with HW_IF_POSITION (-Wsubobject-linkage)

---------

Co-authored-by: Mathias Lüdtke <[email protected]>
(cherry picked from commit 70e282f)

Co-authored-by: Noel Jiménez García <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants