-
Notifications
You must be signed in to change notification settings - Fork 420
Fix compilation warnings #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation warnings #621
Conversation
To avoid problems with HW_IF_POSITION (-Wsubobject-linkage)
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 35.78% 35.98% +0.20%
==========================================
Files 189 7 -182
Lines 17570 678 -16892
Branches 11592 362 -11230
==========================================
- Hits 6287 244 -6043
+ Misses 994 134 -860
+ Partials 10289 300 -9989
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
@Mergifyio backport humble |
✅ Backports have been created
|
* catch exception by reference * Enforce internal linkage for classes in test_gripper_controllers.hpp To avoid problems with HW_IF_POSITION (-Wsubobject-linkage) --------- Co-authored-by: Mathias Lüdtke <[email protected]> (cherry picked from commit 70e282f)
* catch exception by reference * Enforce internal linkage for classes in test_gripper_controllers.hpp To avoid problems with HW_IF_POSITION (-Wsubobject-linkage) --------- Co-authored-by: Mathias Lüdtke <[email protected]> (cherry picked from commit 70e282f) Co-authored-by: Noel Jiménez García <[email protected]>
This pull request fixes the compilation warnings for this repository.
There are more warnings about the usage of deprecated methods but there is already another pull request ( for humble #616) for that.