Add example of starting controllers with launch files#273
Add example of starting controllers with launch files#273christophfroehlich wants to merge 1 commit intoros-controls:masterfrom
Conversation
Co-authored-by: Victor Lopez <victor.lopez@pal-robotics.com>
destogl
left a comment
There was a problem hiding this comment.
I like the docs extension and showing how controllers are managed. Nevertheless, I am not convinced that we need this launch file. We have great CLI options, and they can do everything required, so what is the added value into having this launch file.
@v-lopez if you are still there, please tell us.
Still, @bmagyar and @christophfroehlich, what do you think about his additional option? Is there something I don't see?
| ros2 control load_controller joint_trajectory_position_controller | ||
|
|
||
| .. code-block:: shell | ||
| what should return ``Successfully loaded controller joint_trajectory_position_controller``. Check the status |
There was a problem hiding this comment.
| what should return ``Successfully loaded controller joint_trajectory_position_controller``. Check the status | |
| what should return ``Successfully loaded controller joint_trajectory_position_controller``. | |
| Then check controllers' status |
| ros2 control list_controllers | ||
|
|
||
| .. code-block:: shell | ||
| what shows you that the controller is loaded but unconfigured. |
There was a problem hiding this comment.
| what shows you that the controller is loaded but unconfigured. | |
| what shows you that the controller is loaded but unconfigured. Similar output is expected: |
|
The diff view is broken here, this PR actually only adds literal c in line 167. The rest is just restructuring of the section. I found the old PR interesting and merged it to the new structure. I thought it could be helpful for switching controller from some external interface like a GUI, or probably shows how to integrate |
olivier-stasse
left a comment
There was a problem hiding this comment.
For a first example I believe that the most simple example is preferable.
We can give a try but I think most of the feedback we had was that simpler is better.
|
I don't have any hard feelings about this PR. If you think this is not adding any value to the demos but only making them more verbose -> I'll close it. |
Rewrite of #66