Make ControllerManager tests more flexible and reusable for different scenarios. Use more parameterized tests regarding strictness.#661
Merged
bmagyar merged 2 commits intoros-controls:masterfrom Mar 17, 2022
Conversation
github-actions
bot
requested review from
Serafadam,
UsamaHamayun1,
bmagyar,
jaron-l,
kellyprankin and
livanov93
… scenarios. Use more parameterized tests regarding strictness.
destogl
force-pushed
the
parameterizable-cm-tests
branch
from
806110f to
ec9a0b6
Compare
bmagyar
reviewed
Mar 16, 2022
bmagyar
approved these changes
Mar 16, 2022
Member
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
looks ok except for the typo ;)
livanov93
approved these changes
Mar 17, 2022
pac48
pushed a commit
to pac48/ros2_control
that referenced
this pull request
Jan 26, 2024
… (ros-controls#661) (cherry picked from commit a3f2a16)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces templates to controller manager tests to enable easier reuse of the base classes and methods in different scenarios.
Furthermore, parameterized tests from #582 are extended to other test scenarios. All shared logic and structures are put into a common file.
The main motivation for this changes comes from work on tests for chained controllers and attempting to reduce the amount of repetitive code in those.