Skip to content

Install spawner/unspawner using console_script entrypoint#607

Merged
bmagyar merged 1 commit into
ros-controls:masterfrom
wmmc88:wmmc88/controller-manager-console-scripts
Feb 16, 2022
Merged

Install spawner/unspawner using console_script entrypoint#607
bmagyar merged 1 commit into
ros-controls:masterfrom
wmmc88:wmmc88/controller-manager-console-scripts

Conversation

@wmmc88
Copy link
Copy Markdown
Contributor

@wmmc88 wmmc88 commented Jan 6, 2022

fixes #605

@wmmc88 wmmc88 force-pushed the wmmc88/controller-manager-console-scripts branch 3 times, most recently from 278448d to f546cee Compare January 6, 2022 05:05
@wmmc88 wmmc88 marked this pull request as draft January 6, 2022 06:20
@wmmc88 wmmc88 force-pushed the wmmc88/controller-manager-console-scripts branch from c0c34f8 to f546cee Compare January 6, 2022 17:22
@wmmc88
Copy link
Copy Markdown
Contributor Author

wmmc88 commented Jan 6, 2022

builds failing because the backported feature hasn't been released yet.

Feature: May 10 2021
Galactic Backport: Dec 7 2021
Latest Ament_cmake release: Oct 29 2021

@wmmc88 wmmc88 marked this pull request as ready for review January 6, 2022 17:25
@destogl destogl requested review from bmagyar and destogl January 7, 2022 07:54
@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented Jan 12, 2022

ament/ament_cmake#373

@wmmc88 wmmc88 force-pushed the wmmc88/controller-manager-console-scripts branch from f546cee to 9d396ad Compare January 17, 2022 00:20
@destogl
Copy link
Copy Markdown
Member

destogl commented Jan 18, 2022

@wmmc88 it seems you missed some argument:

  CMake Error at /opt/ros/galactic/share/ament_cmake_python/cmake/ament_python_install_package.cmake:39 (message):
    ament_python_install_package() called with unused arguments:
    SCRIPTS_DESTINATION;lib/controller_manager
  Call Stack (most recent call first):
    /opt/ros/galactic/share/ament_cmake_python/cmake/ament_python_install_package.cmake:33 (_ament_cmake_python_install_package)
    CMakeLists.txt:156 (ament_python_install_package)

@wmmc88
Copy link
Copy Markdown
Contributor Author

wmmc88 commented Jan 18, 2022

@wmmc88 it seems you missed some argument:

  CMake Error at /opt/ros/galactic/share/ament_cmake_python/cmake/ament_python_install_package.cmake:39 (message):
    ament_python_install_package() called with unused arguments:
    SCRIPTS_DESTINATION;lib/controller_manager
  Call Stack (most recent call first):
    /opt/ros/galactic/share/ament_cmake_python/cmake/ament_python_install_package.cmake:33 (_ament_cmake_python_install_package)
    CMakeLists.txt:156 (ament_python_install_package)

That doesn't fail once ament_cmake releases to galactic. It's a new arg that was added a while ago

@destogl
Copy link
Copy Markdown
Member

destogl commented Jan 18, 2022

That doesn't fail once ament_cmake releases to galactic. It's a new arg that was added a while ago

OK, then we just have to wait.

@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented Jan 18, 2022

The release was made, we only need to wait for the next sync with this

Copy link
Copy Markdown
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmagyar I am approving this so we can simply retrigger CI and merge this (tomorrow).

@wmmc88
Copy link
Copy Markdown
Contributor Author

wmmc88 commented Feb 2, 2022

@bmagyar I am approving this so we can simply retrigger CI and merge this (tomorrow).

I think last Friday was only a rolling sync. Idk when the next galactic sync is but there hasn't been one since 12-27-21. Next foxy sync is 2-8-22 (https://discourse.ros.org/t/preparing-for-foxy-sync-and-patch-release-2022-02-08/24050) so maybe soon?

@wmmc88
Copy link
Copy Markdown
Contributor Author

wmmc88 commented Feb 10, 2022

@wmmc88
Copy link
Copy Markdown
Contributor Author

wmmc88 commented Feb 15, 2022

All ci passes after sync!

@bmagyar bmagyar merged commit a3f179c into ros-controls:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spawner/unspawner cannot be run directly on windows

3 participants