check_controllers_running: Make timeout a parameter #2278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
github-actions
bot
requested review from
aprotyas,
bijoua29,
bmagyar,
destogl,
erickisos,
fmauch and
livanov93
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2278 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02%
==========================================
Files 143 143
Lines 16485 16485
Branches 1425 1425
==========================================
- Hits 14663 14661 -2
- Misses 1271 1272 +1
- Partials 551 552 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
approved these changes
May 25, 2025
Member
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
LGTM. Any further changes needed on gz side?
Contributor
Author
|
yes, I haven't changed the timeout value. but we need to release this change first |
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2025
(cherry picked from commit bc522bd)
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2025
(cherry picked from commit bc522bd)
This was referenced May 25, 2025
christophfroehlich
added a commit
that referenced
this pull request
May 25, 2025
(cherry picked from commit bc522bd) Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich
added a commit
that referenced
this pull request
May 25, 2025
(cherry picked from commit bc522bd) Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adressing ros-controls/ros2_control_ci#341