Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let sensors also export state interfaces of joints #1885

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

christophfroehlich
Copy link
Contributor

  • Let sensor export also state interfaces of joints
  • Fix returned no state interfaces warning

@christophfroehlich christophfroehlich changed the title Let sensor export also state interfaces of joints Let sensors also export state interfaces of joints Nov 24, 2024
saikishor
saikishor previously approved these changes Nov 25, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM

hardware_interface/src/resource_manager.cpp Outdated Show resolved Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.96%. Comparing base (41d7393) to head (fde0180).

Files with missing lines Patch % Lines
...dware_interface/test/test_component_interfaces.cpp 93.61% 3 Missing ⚠️
...ce/include/hardware_interface/sensor_interface.hpp 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   88.01%   87.96%   -0.05%     
==========================================
  Files         121      121              
  Lines       12404    12448      +44     
  Branches     1105     1107       +2     
==========================================
+ Hits        10917    10950      +33     
- Misses       1083     1091       +8     
- Partials      404      407       +3     
Flag Coverage Δ
unittests 87.96% <92.98%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/src/resource_manager.cpp 73.39% <ø> (ø)
...e/test/test_component_interfaces_custom_export.cpp 88.79% <100.00%> (-0.10%) ⬇️
...ce/include/hardware_interface/sensor_interface.hpp 92.15% <87.50%> (-1.03%) ⬇️
...dware_interface/test/test_component_interfaces.cpp 96.32% <93.61%> (-1.30%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants