Merged
Conversation
destogl
approved these changes
Nov 5, 2020
Member
There was a problem hiding this comment.
It looks good.
I have a few comments, but nothing ground-braking :)
Are these python test files really needed? It looks like a lot of copy-paste action across many repositories (@Karsten1987 )?
Karsten1987
reviewed
Nov 5, 2020
Karsten1987
approved these changes
Nov 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 34.61% 34.61%
=======================================
Files 52 52
Lines 2981 2981
Branches 1855 1855
=======================================
Hits 1032 1032
Misses 310 310
Partials 1639 1639
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added command line interface for controller manager
Missing unit tests, waiting until we have a controller manager node or something similar like what is proposed on #147 or I could do them with mock services.
Implemented verbs:
list
list_types
load
reload_libraries
switch
$ ros2 control switch -h usage: ros2 control switch [-h] [--spin-time SPIN_TIME] [--no-daemon] [--stop-controllers [STOP_CONTROLLERS [STOP_CONTROLLERS ...]]] [--start-controllers [START_CONTROLLERS [START_CONTROLLERS ...]]] [--strict] [--start-asap] [--switch-timeout SWITCH_TIMEOUT] [-c CONTROLLER_MANAGER] [--include-hidden-nodes] Switch controllers in a controller manager optional arguments: -h, --help show this help message and exit --spin-time SPIN_TIME Spin time in seconds to wait for discovery (only applies when not using an already running daemon) --stop-controllers [STOP_CONTROLLERS [STOP_CONTROLLERS ...]] Name of the controllers to be stopped --start-controllers [START_CONTROLLERS [START_CONTROLLERS ...]] Name of the controllers to be started --strict Strict switch --start-asap Start asap controllers --switch-timeout SWITCH_TIMEOUT Timeout for switching controllers -c CONTROLLER_MANAGER, --controller-manager CONTROLLER_MANAGER Name of the controller manager ROS node --include-hidden-nodes Consider hidden nodes as wellunload