Use ament_cmake generated rclcpp version header#1448
Merged
bmagyar merged 2 commits intoros-controls:masterfrom Mar 26, 2024
Merged
Use ament_cmake generated rclcpp version header#1448bmagyar merged 2 commits intoros-controls:masterfrom
bmagyar merged 2 commits intoros-controls:masterfrom
Conversation
github-actions
bot
requested review from
DasRoteSkelett,
bijoua29,
bmagyar,
destogl,
fmauch,
livanov93 and
progtologist
fmauch
approved these changes
Mar 20, 2024
Contributor
fmauch
left a comment
fmauch
left a comment
There was a problem hiding this comment.
That seems like a very nice change!
christophfroehlich
approved these changes
Mar 20, 2024
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Nice! I didn't know about the ament_generate_version_header
bmagyar
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros2/rclcpp#1805
The Humble version of
rclcppalso contains thisversion.hheader, so this should be compilable on older version. I've tested it on both Rolling and Humble