Skip to content

Robot control components#123

Closed
destogl wants to merge 39 commits intoros-controls:masterfrom
destogl:robot_control_components
Closed

Robot control components#123
destogl wants to merge 39 commits intoros-controls:masterfrom
destogl:robot_control_components

Conversation

@destogl
Copy link
Copy Markdown
Member

@destogl destogl commented Jul 15, 2020

The third part of #101.

Depends on #121.

@destogl destogl requested review from Karsten1987 and bmagyar July 15, 2020 08:04
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #123 into master will decrease coverage by 8.09%.
The diff coverage is 16.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   45.85%   37.75%   -8.10%     
==========================================
  Files          38       40       +2     
  Lines        1230     1703     +473     
  Branches      648     1044     +396     
==========================================
+ Hits          564      643      +79     
- Misses         72       89      +17     
- Partials      594      971     +377
Flag Coverage Δ
#unittests 37.75% <16.70%> (-8.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hardware_interface/test/test_component_parser.cpp 10.05% <10.05%> (ø)
hardware_interface/src/component_parser.cpp 43.15% <43.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1fad5...210694b. Read the comment docs.

@destogl destogl mentioned this pull request Jul 28, 2020
Closed
bmagyar
bmagyar requested changes Jul 29, 2020
View reviewed changes
robot_control_components/CMakeLists.txt Outdated

# Default to C99
if(NOT CMAKE_C_STANDARD)
set(CMAKE_C_STANDARD 99)
Copy link
Copy Markdown
Member

@bmagyar bmagyar Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to ask. Why are we bothering to set cmake standards here @Karsten1987 ?

Copy link
Copy Markdown
Contributor

@Karsten1987 Karsten1987 Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the C standard doesn't have to be set here as we won't have any C-only files present. Pretty sure it's just part of the package template.

Copy link
Copy Markdown
Member

@bmagyar bmagyar Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, I've seen it in plenty of other packages and wasn't sure if it's needed for idl stuff

@destogl destogl force-pushed the robot_control_components branch from a2d4729 to b56632b Compare August 19, 2020 11:37
destogl and others added 15 commits August 19, 2020 14:04
@destogl
Correct all tests
285e42c
@destogl
Initial version of new package implementing components for controling…
19cba1f 
… the robot.
@destogl
Add control component interfaces.
c783704
@destogl
Added initial tests for Joint and JointInterface
02d3ea7
@destogl
Extended SensorInterface to work with hardware. Added Example for Dum…
7443f6b 
…mySensor and HW in tests. Added lifecycle management for components ros-controls#107
@destogl
Added tests for all interfaces and implemented review comments
e4bd372
@destogl
Added HardwareInfo as the main structure in the robot's URDF file
e236fd0
@destogl
Add Hardware and Component base classes and tests.
cf500cd
@destogl @Karsten1987
Update hardware_interface/include/hardware_interface/sensor_hardware_…
8151f6b 
…interface.hpp

Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@destogl @Karsten1987
Update hardware_interface/include/hardware_interface/system_hardware_…
d8257b4 
…interface.hpp

Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@destogl @Karsten1987
Update hardware_interface/include/hardware_interface/system_hardware_…
7051ae2 
…interface.hpp

Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@destogl @Karsten1987
Update hardware_interface/include/hardware_interface/system_hardware_…
91c5705 
…interface.hpp

Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@destogl
Split Component and Hardware Infos into two files
9bf0c43
@destogl
Use separated headers for components_info and hardware_info
36e53a5
@destogl
Style corrections
9d16847
@destogl destogl force-pushed the robot_control_components branch from b56632b to c829d2e Compare August 20, 2020 18:31
@destogl destogl mentioned this pull request Aug 21, 2020
Closed
@destogl
Copy link
Copy Markdown
Member Author

destogl commented Aug 21, 2020

@bmagyar can you assign this to the project "ros2_control new HW Interfaces design and examples in demo repository" somehow I do not have access to it...

@destogl destogl mentioned this pull request Aug 21, 2020
Closed
5 tasks
@Karsten1987
Merge remote-tracking branch 'origin/master' into robot_control_compo…
95cd51e 
…nents
@Karsten1987
linters
210694b 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987
fix package.xml
e6cc5d7 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987
Copy link
Copy Markdown
Contributor

Karsten1987 commented Aug 26, 2020

closing this in favor of #127
@destogl please feel free to re-open this if I've been mistaken.

@destogl
Copy link
Copy Markdown
Member Author

destogl commented Sep 7, 2020

This is actually the third part of #80. Because of a lot of changes in #121 and #127 I will reopen a new one as soon as the latter is merged.

@destogl destogl deleted the robot_control_components branch September 10, 2020 09:37
destogl pushed a commit to b-robotized-forks/ros2_control that referenced this pull request Aug 11, 2022
@bmagyar
Remove components namespace (ros-controls#123)
efaab9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmagyar bmagyar bmagyar requested changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@destogl @codecov-commenter @Karsten1987 @bmagyar