[ntuple] Implement minimal Python API #17104
Open
+159
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes REntry a bit more standalone from the model.
This makes entries standalone from the lifetime of the model and its fields, which will be important for the Python API.
This will allow user-friendly pythonizations of REntry.
This is used for REntry::EnsureMatchingModel().
They only make sense with shared pointers from MakeField, which is hard to use from Python. Also the lifetime of the default entry is tied to that of the RNTupleModel. Forcing the user to create explicit entries, which are fully decoupled from other lifetimes, allows them to be passed around freely and play much nicer with Python.
Make it behave like a dictionary that automatically gets the field type and uses it internally.
hahnjo
requested review from
bellenot,
dpiparo and
vepadulano
as code owners
Test Results 18 files 18 suites 4d 6h 13m 49s ⏱️ For more details on these failures, see this check. Results for commit 830435f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbid default entries in Python, pythonize
REntryto behave as a dict, and provide context manager functions forRNTupleWriter.(depends on #17053)