[ntuple] Cache and expose field type name in REntry #17053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
approved these changes
Nov 26, 2024
pcanal
reviewed
Nov 26, 2024
pcanal
reviewed
Nov 26, 2024
Test Results 18 files 18 suites 4d 6h 36m 10s ⏱️ Results for commit ea38ecf. ♻️ This comment has been updated with latest results. |
This makes REntry a bit more standalone from the model.
This makes entries standalone from the lifetime of the model and its fields, which will be important for the Python API.
This will allow user-friendly pythonizations of REntry.
This is used for REntry::EnsureMatchingModel().
hahnjo
force-pushed
the
ntuple-entry-fieldType
branch
from
28fd968
to
ea38ecf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes entries standalone from the lifetime of the model and its fields, which will be important for the Python API.